Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1412)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1271143003: Fix scroll restoration clamping bug (Closed)

Created:
5 years, 4 months ago by majidvp
Modified:
5 years, 4 months ago
Reviewers:
Nate Chapin
CC:
blink-reviews, tyoshino+watch_chromium.org, gavinp+loader_chromium.org, kinuko+watch, Rick Byers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix scroll restoration clamping bug Ensure that scroll position is not restored if it has to be clamped unless frame is done loading. BUG=517912 TEST=fast/loader/scroll-position-restoration-without-premature-clamping.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200724

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Add tests #

Patch Set 4 : rebase #

Patch Set 5 : Notify progress tracker before trying to restore position #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -4 lines) Patch
A LayoutTests/fast/loader/scroll-position-restoration-without-premature-clamping.html View 1 2 1 chunk +56 lines, -0 lines 0 comments Download
A LayoutTests/fast/loader/scroll-position-restoration-without-premature-clamping-expected.txt View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 2 3 4 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
majidvp
5 years, 4 months ago (2015-08-07 16:55:29 UTC) #2
Nate Chapin
On 2015/08/07 16:55:29, majidvp wrote: Code change is reasonable. Test?
5 years, 4 months ago (2015-08-07 17:02:38 UTC) #3
majidvp
On 2015/08/07 17:02:38, Nate Chapin wrote: > On 2015/08/07 16:55:29, majidvp wrote: > > Code ...
5 years, 4 months ago (2015-08-17 22:14:07 UTC) #4
Nate Chapin
LGTM
5 years, 4 months ago (2015-08-17 22:17:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1271143003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1271143003/80001
5 years, 4 months ago (2015-08-17 22:23:17 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/99332)
5 years, 4 months ago (2015-08-18 01:08:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1271143003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1271143003/80001
5 years, 4 months ago (2015-08-18 12:23:50 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 12:27:26 UTC) #12
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200724

Powered by Google App Engine
This is Rietveld 408576698