components/metrics/variations_seed_store.cc - Issue 1271123003: Componentize VariationsSeedStore and its unittest

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/metrics/variations_seed_store.cc

Issue 1271123003: Componentize VariationsSeedStore and its unittest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@componentize_variations_prefs

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/metrics/DEPS ('K') | « components/metrics/variations_seed_store.h ('k') | components/metrics/variations_seed_store_unittest.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/metrics/variations/variations_seed_store.h"	5 #include "components/metrics/variations_seed_store.h"
	Alexei Svitkine (slow) 2015/08/05 19:52:19 Why metrics and not components/variations? That i Why metrics and not components/variations? That is the eventual place we want this to be. So if it's possible to move it there now, seems preferable to do that in the first place. blundell 2015/08/05 19:54:27 Because it depends on //components/metrics (line 1 Show quoted text On 2015/08/05 19:52:19, Alexei Svitkine wrote: > Why metrics and not components/variations? > > That is the eventual place we want this to be. So if it's possible to move it > there now, seems preferable to do that in the first place. Because it depends on //components/metrics (line 13 below).
6	6

7 #include "base/base64.h"	7 #include "base/base64.h"

8 #include "base/metrics/histogram_macros.h"	8 #include "base/metrics/histogram_macros.h"

9 #include "base/prefs/pref_registry_simple.h"	9 #include "base/prefs/pref_registry_simple.h"

10 #include "base/prefs/pref_service.h"	10 #include "base/prefs/pref_service.h"

11 #include "base/sha1.h"	11 #include "base/sha1.h"

12 #include "base/strings/string_number_conversions.h"	12 #include "base/strings/string_number_conversions.h"

13 #include "components/metrics/compression_utils.h"	13 #include "components/metrics/compression_utils.h"

14 #include "components/variations/pref_names.h"	14 #include "components/variations/pref_names.h"

15 #include "components/variations/proto/variations_seed.pb.h"	15 #include "components/variations/proto/variations_seed.pb.h"

(...skipping 323 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
339 if (verifier.VerifyFinal())	339 if (verifier.VerifyFinal())

340 return VARIATIONS_SEED_SIGNATURE_VALID;	340 return VARIATIONS_SEED_SIGNATURE_VALID;

341 return VARIATIONS_SEED_SIGNATURE_INVALID_SEED;	341 return VARIATIONS_SEED_SIGNATURE_INVALID_SEED;

342 }	342 }

343	343

344 std::string VariationsSeedStore::GetInvalidSignature() const {	344 std::string VariationsSeedStore::GetInvalidSignature() const {

345 return invalid_base64_signature_;	345 return invalid_base64_signature_;

346 }	346 }

347	347

348 } // namespace chrome_variations	348 } // namespace chrome_variations

OLD	NEW