Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1271073002: Delete --harmony-unicode flag (Closed)

Created:
5 years, 4 months ago by adamk
Modified:
5 years, 4 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Delete --harmony-unicode flag It was shipped in V8 4.4. Committed: https://crrev.com/cd455055a0ed6d29798dba13f43c8f5617cd5823 Cr-Commit-Position: refs/heads/master@{#30035}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase and reformat comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -80 lines) Patch
M src/bootstrapper.cc View 1 3 chunks +0 lines, -3 lines 0 comments Download
M src/flag-definitions.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M src/parser.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M src/preparser.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M src/scanner.h View 1 2 chunks +0 lines, -5 lines 0 comments Download
M src/scanner.cc View 1 2 chunks +4 lines, -6 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 4 chunks +2 lines, -8 lines 0 comments Download
M test/mjsunit/es6/templates.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/unicode-escapes.js View 1 chunk +0 lines, -2 lines 0 comments Download
D test/mjsunit/harmony/unicode-escapes.js View 1 chunk +0 lines, -46 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
adamk
5 years, 4 months ago (2015-08-05 00:30:40 UTC) #2
rossberg
lgtm https://codereview.chromium.org/1271073002/diff/1/src/scanner.cc File src/scanner.cc (right): https://codereview.chromium.org/1271073002/diff/1/src/scanner.cc#newcode1078 src/scanner.cc:1078: // Accept both \uxxxx and \u{xxxxxx}. Nit: reformat.
5 years, 4 months ago (2015-08-05 07:58:07 UTC) #3
adamk
https://codereview.chromium.org/1271073002/diff/1/src/scanner.cc File src/scanner.cc (right): https://codereview.chromium.org/1271073002/diff/1/src/scanner.cc#newcode1078 src/scanner.cc:1078: // Accept both \uxxxx and \u{xxxxxx}. On 2015/08/05 07:58:07, ...
5 years, 4 months ago (2015-08-05 18:16:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1271073002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1271073002/20001
5 years, 4 months ago (2015-08-05 18:17:12 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-05 19:08:29 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-05 19:08:51 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cd455055a0ed6d29798dba13f43c8f5617cd5823
Cr-Commit-Position: refs/heads/master@{#30035}

Powered by Google App Engine
This is Rietveld 408576698