Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 1271043002: bluetooth: Add histograms and logging for getPrimaryService() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bluetooth-uma-connecta-gatt
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index b72fb164eaa0fcecad8b508e5ab8699d11b606f1..57d90c7394156ffdabeecac2d804b37da1f58d0d 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -2793,6 +2793,40 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="Bluetooth.Web.GetPrimaryService.Outcome"
+ enum="WebBluetoothGetPrimaryServiceOutcome">
+ <owner>jyasskin@chromium.org</owner>
+ <owner>ortuno@chromium.org</owner>
+ <owner>scheib@chromium.org</owner>
+ <summary>
+ Records the result of a GATTServer.getPrimaryService() call. Used to
+ understand what errors developers are getting so we can target efforts
+ toward the most common ones.
+ </summary>
+</histogram>
+
+<histogram name="Bluetooth.Web.GetPrimaryService.Services"
+ enum="GATTServiceHash">
+ <owner>jyasskin@chromium.org</owner>
+ <owner>ortuno@chromium.org</owner>
+ <owner>scheib@chromium.org</owner>
+ <summary>
+ Records what GATT Services are used when connected. This will help us know
+ if we should build an API for specific services rather than a general
+ Bluetooth API.
+ </summary>
+</histogram>
+
+<histogram name="Bluetooth.Web.GetPrimaryService.Time" units="milliseconds">
+ <owner>jyasskin@chromium.org</owner>
+ <owner>ortuno@chromium.org</owner>
+ <owner>scheib@chromium.org</owner>
+ <summary>
+ Records how long it takes to discover all GATT services in a device. Used to
+ know if we should optimize service discovery code.
+ </summary>
+</histogram>
+
<histogram name="Bluetooth.Web.RequestDevice.Filters.Count" units="filters">
<owner>jyasskin@chromium.org</owner>
<owner>ortuno@chromium.org</owner>
@@ -71754,6 +71788,12 @@ To add a new entry, add it with any value and run test to compute valid value.
<int value="5" label="Characteristic.writeValue()"/>
</enum>
+<enum name="WebBluetoothGetPrimaryServiceOutcome" type="int">
+ <int value="0" label="Success"/>
+ <int value="1" label="Device no longer in range."/>
+ <int value="2" label="No services with provided UUID."/>
+</enum>
+
<enum name="WebBluetoothRequestDeviceOutcome" type="int">
<int value="0" label="Success"/>
<int value="1" label="No Bluetooth adapter"/>

Powered by Google App Engine
This is Rietveld 408576698