Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 127103004: Added --pdf-path flag to enable bisecting pdf or print preview issues with Chromium. (Closed)

Created:
6 years, 11 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 11 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Added --pdf-path flag to enable bisecting pdf or print preview issues with Chromium. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243783

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -4 lines) Patch
M tools/bisect-builds.py View 9 chunks +22 lines, -4 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
Vitaly Buka (NO REVIEWS)
6 years, 11 months ago (2014-01-08 01:53:08 UTC) #1
Robert Sesek
https://codereview.chromium.org/127103004/diff/1/tools/bisect-builds.py File tools/bisect-builds.py (right): https://codereview.chromium.org/127103004/diff/1/tools/bisect-builds.py#newcode377 tools/bisect-builds.py:377: shutil.copy(context.pdf_path, os.path.dirname(context.GetLaunchPath())) Why do you need to copy this? ...
6 years, 11 months ago (2014-01-08 15:31:22 UTC) #2
Vitaly Buka (NO REVIEWS)
On 2014/01/08 15:31:22, rsesek wrote: > https://codereview.chromium.org/127103004/diff/1/tools/bisect-builds.py > File tools/bisect-builds.py (right): > > https://codereview.chromium.org/127103004/diff/1/tools/bisect-builds.py#newcode377 > ...
6 years, 11 months ago (2014-01-08 18:53:24 UTC) #3
Robert Sesek
LGTM
6 years, 11 months ago (2014-01-08 22:19:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/127103004/1
6 years, 11 months ago (2014-01-08 22:32:01 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 05:08:54 UTC) #6
Message was sent while issue was closed.
Change committed as 243783

Powered by Google App Engine
This is Rietveld 408576698