Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Issue 1271003002: Determine whether to disable session invalidations at startup (Closed)

Created:
5 years, 4 months ago by pkotwicz
Modified:
5 years, 4 months ago
Reviewers:
nyquist
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, maniscalco+watch_chromium.org, maxbogue
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Determine whether to disable session invalidations at startup BUG=477054 TEST=InvalidationControllerTest.* Committed: https://crrev.com/4469d4469c152c36f632a6e969b3088e1271340c Cr-Commit-Position: refs/heads/master@{#341761}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -15 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/invalidation/InvalidationController.java View 4 chunks +24 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/invalidation/InvalidationControllerTest.java View 3 chunks +3 lines, -4 lines 0 comments Download
M sync/android/java/src/org/chromium/sync/internal_api/pub/base/ModelType.java View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
pkotwicz
Tommy can you please take a look? This CL is a subset of https://codereview.chromium.org/1263773007/ with ...
5 years, 4 months ago (2015-08-04 18:14:19 UTC) #3
nyquist
that was nice of you! thanks! lgtm
5 years, 4 months ago (2015-08-04 19:16:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1271003002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1271003002/20001
5 years, 4 months ago (2015-08-04 19:18:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 4 months ago (2015-08-04 19:35:11 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-04 19:36:47 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4469d4469c152c36f632a6e969b3088e1271340c
Cr-Commit-Position: refs/heads/master@{#341761}

Powered by Google App Engine
This is Rietveld 408576698