Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1270983002: WebUSB bindings part 4 (Closed)

Created:
5 years, 4 months ago by Ken Rockot(use gerrit already)
Modified:
5 years, 4 months ago
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

WebUSB bindings part 4 This adds USBAlternateInterface and USBEndpoint. BUG=492204 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200002

Patch Set 1 #

Patch Set 2 : update expected interface list #

Total comments: 6

Patch Set 3 : #

Total comments: 2

Patch Set 4 : punctuation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+410 lines, -2 lines) Patch
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 chunks +15 lines, -0 lines 0 comments Download
M Source/modules/modules.gypi View 2 chunks +6 lines, -0 lines 0 comments Download
A Source/modules/webusb/USBAlternateInterface.h View 1 chunk +46 lines, -0 lines 0 comments Download
A Source/modules/webusb/USBAlternateInterface.cpp View 1 2 1 chunk +82 lines, -0 lines 0 comments Download
A Source/modules/webusb/USBAlternateInterface.idl View 1 chunk +19 lines, -0 lines 0 comments Download
A Source/modules/webusb/USBEndpoint.h View 1 2 1 chunk +43 lines, -0 lines 0 comments Download
A Source/modules/webusb/USBEndpoint.cpp View 1 2 3 1 chunk +120 lines, -0 lines 0 comments Download
A Source/modules/webusb/USBEndpoint.idl View 1 2 1 chunk +28 lines, -0 lines 0 comments Download
M Source/modules/webusb/USBInterface.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/modules/webusb/USBInterface.cpp View 2 chunks +9 lines, -0 lines 0 comments Download
M Source/modules/webusb/USBInterface.idl View 1 chunk +1 line, -1 line 0 comments Download
M public/platform/modules/webusb/WebUSBDeviceInfo.h View 2 chunks +39 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Ken Rockot(use gerrit already)
5 years, 4 months ago (2015-08-04 16:46:52 UTC) #2
Reilly Grant (use Gerrit)
https://codereview.chromium.org/1270983002/diff/20001/Source/modules/webusb/USBAlternateInterface.cpp File Source/modules/webusb/USBAlternateInterface.cpp (right): https://codereview.chromium.org/1270983002/diff/20001/Source/modules/webusb/USBAlternateInterface.cpp#newcode25 Source/modules/webusb/USBAlternateInterface.cpp:25: exceptionState.throwRangeError("Invalid alternate index."); "Invalid alternate setting." https://codereview.chromium.org/1270983002/diff/20001/Source/modules/webusb/USBEndpoint.cpp File Source/modules/webusb/USBEndpoint.cpp ...
5 years, 4 months ago (2015-08-04 19:18:09 UTC) #3
Ken Rockot(use gerrit already)
https://codereview.chromium.org/1270983002/diff/20001/Source/modules/webusb/USBAlternateInterface.cpp File Source/modules/webusb/USBAlternateInterface.cpp (right): https://codereview.chromium.org/1270983002/diff/20001/Source/modules/webusb/USBAlternateInterface.cpp#newcode25 Source/modules/webusb/USBAlternateInterface.cpp:25: exceptionState.throwRangeError("Invalid alternate index."); On 2015/08/04 19:18:09, reillyg wrote: > ...
5 years, 4 months ago (2015-08-04 19:29:14 UTC) #4
Reilly Grant (use Gerrit)
lgtm https://codereview.chromium.org/1270983002/diff/40001/Source/modules/webusb/USBEndpoint.cpp File Source/modules/webusb/USBEndpoint.cpp (right): https://codereview.chromium.org/1270983002/diff/40001/Source/modules/webusb/USBEndpoint.cpp#newcode68 Source/modules/webusb/USBEndpoint.cpp:68: exceptionState.throwRangeError("Invalid endpoint direction"); + "."
5 years, 4 months ago (2015-08-04 19:44:24 UTC) #5
Ken Rockot(use gerrit already)
https://codereview.chromium.org/1270983002/diff/40001/Source/modules/webusb/USBEndpoint.cpp File Source/modules/webusb/USBEndpoint.cpp (right): https://codereview.chromium.org/1270983002/diff/40001/Source/modules/webusb/USBEndpoint.cpp#newcode68 Source/modules/webusb/USBEndpoint.cpp:68: exceptionState.throwRangeError("Invalid endpoint direction"); On 2015/08/04 19:44:24, reillyg wrote: > ...
5 years, 4 months ago (2015-08-04 19:47:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1270983002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1270983002/60001
5 years, 4 months ago (2015-08-04 19:47:22 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-04 23:07:54 UTC) #10
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200002

Powered by Google App Engine
This is Rietveld 408576698