Issue 12709005: Revert "Make gm use SkFlags."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12709005: Revert "Make gm use SkFlags." (Closed)

Created:
7 years, 9 months ago by scroggo

Modified:
7 years, 9 months ago

Reviewers:

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Revert "Make gm use SkFlags." Fix the build. This reverts commit 6f1fe2aee39308fc56854b062be244a904c209e7. Committed: https://code.google.com/p/skia/source/detail?r=8236

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+296 lines, -234 lines)			Patch
M	gm/gmmain.cpp	View	24 chunks	+263 lines, -144 lines	0 comments	Download
M	gm/tests/outputs/compared-against-different-pixels-images/output-expected/command_line	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gm/tests/outputs/compared-against-different-pixels-json/output-expected/command_line	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gm/tests/outputs/compared-against-empty-dir/output-expected/command_line	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gm/tests/outputs/compared-against-identical-bytes-images/output-expected/command_line	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gm/tests/outputs/compared-against-identical-bytes-json/output-expected/command_line	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gm/tests/outputs/compared-against-identical-pixels-images/output-expected/command_line	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gm/tests/outputs/compared-against-identical-pixels-json/output-expected/command_line	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gm/tests/outputs/no-readpath/output-expected/command_line	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gm/tests/run.sh	View	5 chunks	+5 lines, -5 lines	0 comments	Download
D	gyp/flags.gyp	View	1 chunk	+0 lines, -29 lines	0 comments	Download
M	gyp/gm.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	gyp/tools.gyp	View	4 chunks	+6 lines, -2 lines	0 comments	Download
M	tools/SkFlags.h	View	5 chunks	+12 lines, -39 lines	0 comments	Download
M	tools/SkFlags.cpp	View	1 chunk	+2 lines, -6 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

scroggo

7 years, 9 months ago (2013-03-19 17:39:07 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r8236 (presubmit successful).

Expand Messages | Collapse Messages