Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 1270873002: GC: Refactor incremental marking steps w/ deadline into a separate call (Closed)

Created:
5 years, 4 months ago by Michael Lippautz
Modified:
5 years, 4 months ago
Reviewers:
ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

GC: Refactor incremental marking steps w/ deadline into a separate call BUG= Committed: https://crrev.com/869ab06ea5165ce0dc01396150a110478f8a3e42 Cr-Commit-Position: refs/heads/master@{#29986}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -13 lines) Patch
M src/heap/heap.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 1 2 chunks +21 lines, -13 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Michael Lippautz
5 years, 4 months ago (2015-08-03 17:47:41 UTC) #2
ulan
lgtm with comment: https://codereview.chromium.org/1270873002/diff/1/src/heap/heap.h File src/heap/heap.h (right): https://codereview.chromium.org/1270873002/diff/1/src/heap/heap.h#newcode2295 src/heap/heap.h:2295: double step_size_in_bytes, double deadline_in_ms, step_size_in_bytes should ...
5 years, 4 months ago (2015-08-03 17:56:09 UTC) #3
Michael Lippautz
https://codereview.chromium.org/1270873002/diff/1/src/heap/heap.h File src/heap/heap.h (right): https://codereview.chromium.org/1270873002/diff/1/src/heap/heap.h#newcode2295 src/heap/heap.h:2295: double step_size_in_bytes, double deadline_in_ms, On 2015/08/03 17:56:09, ulan wrote: ...
5 years, 4 months ago (2015-08-03 17:59:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1270873002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1270873002/20001
5 years, 4 months ago (2015-08-03 17:59:49 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-03 18:25:17 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-03 18:25:27 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/869ab06ea5165ce0dc01396150a110478f8a3e42
Cr-Commit-Position: refs/heads/master@{#29986}

Powered by Google App Engine
This is Rietveld 408576698