Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 127083003: Add an "add_inline_comment" method to rietveld.py (Closed)

Created:
6 years, 11 months ago by David Tseng
Modified:
6 years, 11 months ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org, Peter Lundblad
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Add an "add_inline_comment" method to rietveld.py With the addition of this method, rietveld.py can be used to create cli-based tools to review Chromium code. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=244529

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M rietveld.py View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
David Tseng
6 years, 11 months ago (2014-01-08 00:11:37 UTC) #1
iannucci
On 2014/01/08 00:11:37, David Tseng wrote: FYI: I'm in the process of rewriting rietveld. I'm ...
6 years, 11 months ago (2014-01-08 00:46:18 UTC) #2
David Tseng
Thanks for the heads up. Do you mind if I check this in in the ...
6 years, 11 months ago (2014-01-10 23:59:05 UTC) #3
iannucci
On 2014/01/10 23:59:05, David Tseng wrote: > Thanks for the heads up. Do you mind ...
6 years, 11 months ago (2014-01-11 00:36:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtseng@chromium.org/127083003/30001
6 years, 11 months ago (2014-01-13 17:47:10 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-13 17:48:51 UTC) #6
Message was sent while issue was closed.
Change committed as 244529

Powered by Google App Engine
This is Rietveld 408576698