Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 127083002: **STILLBAKING** Decouple disk cache tests from backends. (Closed)

Created:
6 years, 11 months ago by gavinp
Modified:
6 years, 4 months ago
Reviewers:
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org
Visibility:
Public.

Description

**STILLBAKING** Decouple disk cache tests from backends. The existing disk_cache entry and backend tests are mostly refactored into value parameterized tests in GoogleTest, which are then instantiated for each backend built into your net lib. The instantiation value is a concrete instance of a backend traits class, which allows each backend to customize how it interacts with each test. The result is a suite of tests that are independent of which specific backends are being built with the net lib. With this change, chrome can now be built without net unittests. This CL is downstream of https://codereview.chromium.org/117533003/ BUG=331062

Patch Set 1 #

Patch Set 2 : run on memory backend, add more tests #

Patch Set 3 : rebase to trunk #

Patch Set 4 : partially fix the disk_cache_perftest #

Patch Set 5 : add most tests from simple cache #

Patch Set 6 : test blockfile backend too #

Patch Set 7 : almost all entry tests #

Patch Set 8 : remove spurious re-add #

Patch Set 9 : remove spurious re-add #

Patch Set 10 : confusing mix of rebase and backend tests arriving #

Patch Set 11 : fix blockfile free build #

Patch Set 12 : fix blockfile free build #

Patch Set 13 : fix blockfile free build #

Patch Set 14 : add some blockfile specific tests... #

Patch Set 15 : remove undead test #

Patch Set 16 : most backend tests #

Patch Set 17 : rebase to trunk #

Patch Set 18 : more complete #

Patch Set 19 : more complete #

Patch Set 20 : rebase #

Patch Set 21 : remove phantom entry_unittest.cc #

Patch Set 22 : rebase to upstream CLs #

Patch Set 23 : rebase to upstream #

Patch Set 24 : rebase to upstream again... #

Patch Set 25 : upstream rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6202 lines, -8033 lines) Patch
M net/base/cache_type.h View 1 chunk +3 lines, -2 lines 0 comments Download
A net/disk_cache/backend_tests.h View 1 2 3 4 5 6 7 8 9 1 chunk +16 lines, -0 lines 0 comments Download
A net/disk_cache/backend_tests.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +468 lines, -0 lines 0 comments Download
D net/disk_cache/backend_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 1 chunk +0 lines, -3498 lines 0 comments Download
M net/disk_cache/blockfile/backend_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 1 chunk +2 lines, -1 line 0 comments Download
M net/disk_cache/blockfile/disk_cache_perftest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 10 chunks +23 lines, -19 lines 0 comments Download
M net/disk_cache/cache_creator.cc View 1 2 3 4 5 6 7 8 9 23 24 1 chunk +1 line, -1 line 0 comments Download
A net/disk_cache/disk_cache_test.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +156 lines, -0 lines 0 comments Download
A net/disk_cache/disk_cache_test.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +215 lines, -0 lines 0 comments Download
D net/disk_cache/disk_cache_test_base.h View 1 chunk +0 lines, -176 lines 0 comments Download
D net/disk_cache/disk_cache_test_base.cc View 23 24 1 chunk +0 lines, -322 lines 0 comments Download
M net/disk_cache/disk_cache_test_util.h View 1 2 3 4 5 6 7 8 9 14 15 16 17 2 chunks +9 lines, -4 lines 0 comments Download
M net/disk_cache/disk_cache_test_util.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 2 chunks +3 lines, -18 lines 0 comments Download
A net/disk_cache/entry_sync_tests.h View 1 2 3 4 5 6 1 chunk +16 lines, -0 lines 0 comments Download
A net/disk_cache/entry_sync_tests.cc View 1 2 3 4 5 6 1 chunk +179 lines, -0 lines 0 comments Download
A net/disk_cache/entry_tests.h View 1 2 3 4 5 6 1 chunk +16 lines, -0 lines 0 comments Download
A net/disk_cache/entry_tests.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +1553 lines, -0 lines 0 comments Download
D net/disk_cache/entry_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 18 19 20 23 24 1 chunk +0 lines, -3975 lines 0 comments Download
A net/disk_cache/memory/memory_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +80 lines, -0 lines 0 comments Download
A net/disk_cache/simple/simple_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 1 chunk +1792 lines, -0 lines 0 comments Download
A net/disk_cache/v2/blockfile_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 1 chunk +1644 lines, -0 lines 0 comments Download
M net/net.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 3 chunks +26 lines, -17 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
gavinp
rebase
6 years, 11 months ago (2014-01-22 00:48:12 UTC) #1
gavinp
6 years, 11 months ago (2014-01-22 18:48:23 UTC) #2
remove phantom entry_unittest.cc

Powered by Google App Engine
This is Rietveld 408576698