Chromium Code Reviews

Issue 1270823003: [Merge M45][SafeBrowsing] Send pings for Zip files that contain other archives. (Closed)

Created:
5 years, 4 months ago by asanka
Modified:
5 years, 4 months ago
Reviewers:
asanka
CC:
chromium-reviews, grt+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2454
Target Ref:
refs/pending/branch-heads/2454
Project:
chromium
Visibility:
Public.

Description

[Merge M45][SafeBrowsing] Send pings for Zip files that contain other archives. BUG=515216 Review URL: https://codereview.chromium.org/1262753002 Cr-Commit-Position: refs/heads/master@{#341475} (cherry picked from commit 04a4eb914ba76b0a1ee8b776bcf53a429ba45fe2) TBR=asanka@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/c760996f8cd2319dba0b770c66789c21ace71b0c

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+280 lines, -56 lines)
M chrome/browser/safe_browsing/download_protection_service.cc View 4 chunks +44 lines, -11 lines 0 comments
M chrome/browser/safe_browsing/download_protection_service_unittest.cc View 2 chunks +56 lines, -0 lines 0 comments
M chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc View 1 chunk +1 line, -1 line 0 comments
M chrome/browser/safe_browsing/sandboxed_zip_analyzer_unittest.cc View 5 chunks +92 lines, -21 lines 0 comments
M chrome/common/chrome_utility_messages.h View 1 chunk +1 line, -0 lines 0 comments
M chrome/common/safe_browsing/csd.proto View 1 chunk +2 lines, -1 line 0 comments
M chrome/common/safe_browsing/download_protection_util.h View 1 chunk +2 lines, -2 lines 0 comments
M chrome/common/safe_browsing/download_protection_util.cc View 2 chunks +39 lines, -9 lines 0 comments
M chrome/common/safe_browsing/zip_analyzer.cc View 3 chunks +14 lines, -11 lines 0 comments
M chrome/common/safe_browsing/zip_analyzer_results.h View 2 chunks +4 lines, -0 lines 0 comments
A chrome/test/data/safe_browsing/download_protection/zipfile_archive_and_binaries.zip View Binary file 0 comments
A chrome/test/data/safe_browsing/download_protection/zipfile_archive_no_binaries.zip View Binary file 0 comments
A chrome/test/data/safe_browsing/download_protection/zipfile_one_jse_file.zip View Binary file 0 comments
A chrome/test/data/safe_browsing/download_protection/zipfile_rar_archive_no_binaries.zip View Binary file 0 comments
M tools/metrics/histograms/histograms.xml View 2 chunks +25 lines, -0 lines 0 comments

Messages

Total messages: 1 (0 generated)
asanka
5 years, 4 months ago (2015-08-04 16:20:34 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c760996f8cd2319dba0b770c66789c21ace71b0c (presubmit successful).

Powered by Google App Engine