Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Unified Diff: runtime/vm/instructions_ia32_test.cc

Issue 1270803003: VM: More abstract interface for generating stub calls. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/instructions_arm_test.cc ('k') | runtime/vm/instructions_mips_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/instructions_ia32_test.cc
diff --git a/runtime/vm/instructions_ia32_test.cc b/runtime/vm/instructions_ia32_test.cc
index e82bad6572def5d67464b48b1ddd9286fa7465f6..cace22907f15c72106f9cd0599f6d68407f57542 100644
--- a/runtime/vm/instructions_ia32_test.cc
+++ b/runtime/vm/instructions_ia32_test.cc
@@ -17,22 +17,22 @@ namespace dart {
#define __ assembler->
ASSEMBLER_TEST_GENERATE(Call, assembler) {
- __ call(&StubCode::InvokeDartCodeLabel());
+ __ Call(*StubCode::InvokeDartCode_entry());
__ ret();
}
ASSEMBLER_TEST_RUN(Call, test) {
CallPattern call(test->entry());
- EXPECT_EQ(StubCode::InvokeDartCodeLabel().address(),
+ EXPECT_EQ(StubCode::InvokeDartCode_entry()->EntryPoint(),
call.TargetAddress());
}
ASSEMBLER_TEST_GENERATE(Jump, assembler) {
- __ jmp(&StubCode::InvokeDartCodeLabel());
- const ExternalLabel array_label(StubCode::AllocateArrayEntryPoint());
- __ jmp(&array_label);
+ __ Jmp(*StubCode::InvokeDartCode_entry());
+ const ExternalLabel label(StubCode::AllocateArray_entry()->EntryPoint());
+ __ jmp(&label);
__ ret();
}
@@ -46,7 +46,7 @@ ASSEMBLER_TEST_RUN(Jump, test) {
VirtualMemory::kReadWrite);
EXPECT(status);
JumpPattern jump1(test->entry(), test->code());
- EXPECT_EQ(StubCode::InvokeDartCodeLabel().address(),
+ EXPECT_EQ(StubCode::InvokeDartCode_entry()->EntryPoint(),
jump1.TargetAddress());
JumpPattern jump2(test->entry() + jump1.pattern_length_in_bytes(),
test->code());
@@ -60,7 +60,7 @@ ASSEMBLER_TEST_RUN(Jump, test) {
jump2.SetTargetAddress(target1);
EXPECT_EQ(array_stub.EntryPoint(),
jump1.TargetAddress());
- EXPECT_EQ(StubCode::InvokeDartCodeLabel().address(),
+ EXPECT_EQ(StubCode::InvokeDartCode_entry()->EntryPoint(),
jump2.TargetAddress());
}
« no previous file with comments | « runtime/vm/instructions_arm_test.cc ('k') | runtime/vm/instructions_mips_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698