Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 12708003: Wait in heap tests for active concurrent sweeper threads. (Closed)

Created:
7 years, 9 months ago by Hannes Payer (out of office)
Modified:
7 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Wait in heap tests for active concurrent sweeper threads. BUG= Committed: https://code.google.com/p/v8/source/detail?r=13895

Patch Set 1 #

Total comments: 5

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M test/cctest/test-heap.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Hannes Payer (out of office)
7 years, 9 months ago (2013-03-08 18:52:40 UTC) #1
Michael Starzinger
https://codereview.chromium.org/12708003/diff/1/src/mark-compact.h File src/mark-compact.h (right): https://codereview.chromium.org/12708003/diff/1/src/mark-compact.h#newcode701 src/mark-compact.h:701: bool sweeping_pending() const { Drop this in favor of ...
7 years, 9 months ago (2013-03-11 09:50:26 UTC) #2
Hannes Payer (out of office)
https://codereview.chromium.org/12708003/diff/1/src/mark-compact.h File src/mark-compact.h (right): https://codereview.chromium.org/12708003/diff/1/src/mark-compact.h#newcode701 src/mark-compact.h:701: bool sweeping_pending() const { On 2013/03/11 09:50:26, Michael Starzinger ...
7 years, 9 months ago (2013-03-11 10:14:52 UTC) #3
Michael Starzinger
LGTM.
7 years, 9 months ago (2013-03-11 10:15:36 UTC) #4
Hannes Payer (out of office)
7 years, 9 months ago (2013-03-11 10:23:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r13895 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698