Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1270793002: [Android WebView] Put error page files into WebView resources (Closed)

Created:
5 years, 4 months ago by mnaganov (inactive)
Modified:
5 years, 4 months ago
Reviewers:
Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android WebView] Put error page files into WebView resources Historically, the load error pages displayed by WebView were a part of Android framework resources. This change adds them into WebView resources. This way, the pages will be accessible to sandboxed child services, using Chromium's resource sharing mechanisms. Unlike Chrome's error pages, which use WebUI, WebView pages are completely static, as JavaScript can be disabled. BUG=515691 Committed: https://crrev.com/f082f6cb6e1c2b57554bb9b91b6dbd7214027c4f Cr-Commit-Position: refs/heads/master@{#341951}

Patch Set 1 #

Patch Set 2 : Added RTL direction support #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -126 lines) Patch
M android_webview/android_webview.gyp View 2 chunks +9 lines, -0 lines 0 comments Download
M android_webview/common/aw_resource.h View 1 chunk +1 line, -2 lines 0 comments Download
M android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java View 1 chunk +0 lines, -1 line 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwResource.java View 4 chunks +1 line, -80 lines 0 comments Download
M android_webview/native/aw_resource.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M android_webview/renderer/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M android_webview/renderer/aw_content_renderer_client.cc View 1 4 chunks +28 lines, -9 lines 0 comments Download
A android_webview/renderer/aw_renderer_resources.grd View 1 chunk +28 lines, -0 lines 0 comments Download
A android_webview/renderer/resources/load_error.html View 1 1 chunk +20 lines, -0 lines 0 comments Download
A android_webview/renderer/resources/suggestions.html View 1 chunk +6 lines, -0 lines 0 comments Download
D android_webview/test/shell/res/raw/blank_html.html View 1 chunk +0 lines, -5 lines 0 comments Download
D android_webview/test/shell/res/raw/error.html View 1 chunk +0 lines, -6 lines 0 comments Download
M android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellResourceProvider.java View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/gritsettings/resource_ids View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
mnaganov (inactive)
5 years, 4 months ago (2015-08-03 16:25:31 UTC) #2
mnaganov (inactive)
Ping!
5 years, 4 months ago (2015-08-04 17:33:09 UTC) #3
Torne
lgtm
5 years, 4 months ago (2015-08-05 12:14:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1270793002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1270793002/20001
5 years, 4 months ago (2015-08-05 15:38:13 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/52201)
5 years, 4 months ago (2015-08-05 17:20:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1270793002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1270793002/20001
5 years, 4 months ago (2015-08-05 17:21:43 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-05 20:10:00 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-05 20:10:40 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f082f6cb6e1c2b57554bb9b91b6dbd7214027c4f
Cr-Commit-Position: refs/heads/master@{#341951}

Powered by Google App Engine
This is Rietveld 408576698