ui/gfx/vector_icons/find_close.icon - Issue 1270783005: V1 of material design find in page bar

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/gfx/vector_icons/find_close.icon

Issue 1270783005: V1 of material design find in page bar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: mvp Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // A variant of ic_close with rounded corners.
	sky 2015/08/05 00:06:01 Random comment on these. Should we be adding copyr Random comment on these. Should we be adding copyrights? Evan Stade 2015/08/05 19:04:25 I dunno, this rule seems ambiguous in this case: " Show quoted text On 2015/08/05 00:06:01, sky wrote: > Random comment on these. Should we be adding copyrights? I dunno, this rule seems ambiguous in this case: "Every file containing source code must include copyright and license information." We don't have any copyright notice on .png files AFAIK, but I can ping a lawyer. I added the comments in case people came along and wondered why we weren't just using ic_close (i.e. skiafying the SVG paths) since these icons closely resemble those icons.
	2 CANVAS_DIMENSIONS, 32,

	3 STROKE, 3.5,

	4 MOVE_TO, 8.75, 8.75,

	5 R_LINE_TO, 14.5, 14.5,

	6 MOVE_TO, 8.75, 23.25,

	7 R_LINE_TO, 14.5, -14.5,

	8 END

OLD	NEW