V1 of material design find in page bar

ui/gfx/vector_icons/aggregate_vector_icons.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import fileinput
 import glob
 import optparse
 import os
 import textwrap
 
@@ skipping 10 matching lines @@
 
   icon_list = glob.glob(working_directory + "*.icon")
 
   input_header_template = open(os.path.join(working_directory,
                                             "vector_icons.h.template"))
   header_template_contents = input_header_template.readlines()
   input_header_template.close()
   output_header = open(output_h, "w")
   for line in header_template_contents:
     if not "TEMPLATE_PLACEHOLDER" in line:
       output_header.write(line)

[Justin Donnelly, 2015/08/05 14:32:49]

How about a continue here to match the new structure of the code below?

[Evan Stade, 2015/08/05 19:04:25]

Done.

     else:
       for icon_path in icon_list:
+        # The icon name should be of the format "foo.icon" or "foo.1x.icon".
         (icon_name, extension) = os.path.splitext(os.path.basename(icon_path))
-        output_header.write("  {},\n".format(icon_name.upper()))
+        (icon_name, scale_factor) = os.path.splitext(
+            os.path.basename(icon_name))

[Justin Donnelly, 2015/08/05 14:32:49]

You don't need os.path.basename here, you already got rid of the path above.

[Evan Stade, 2015/08/05 19:04:25]

Done.

+        if not scale_factor:
+          output_header.write("  {},\n".format(icon_name.upper()))
   output_header.close()
 
   input_cc_template = open(
       os.path.join(working_directory, "vector_icons.cc.template"))
   cc_template_contents = input_cc_template.readlines()
   input_cc_template.close()
   output_cc = open(output_cc, "w")
   for line in cc_template_contents:
     if not "TEMPLATE_PLACEHOLDER" in line:
       output_cc.write(line)
-    else:
-      for icon_path in icon_list:
-        (icon_name, extension) = os.path.splitext(os.path.basename(icon_path))
-        icon_file = open(icon_path)
-        vector_commands = "".join(icon_file.readlines())
-        icon_file.close()
-        output_cc.write("ICON_TEMPLATE({}, {})\n".format(icon_name.upper(),
-                                                         vector_commands))
+      continue;
+
+    for icon_path in icon_list:
+      (icon_name, extension) = os.path.splitext(os.path.basename(icon_path))
+      (icon_name, scale_factor) = os.path.splitext(os.path.basename(icon_name))

[Justin Donnelly, 2015/08/05 14:32:49]

Ditto

[Evan Stade, 2015/08/05 19:04:25]

Done.

+      assert not scale_factor or scale_factor == ".1x"
+      if (("1X" in line and scale_factor != ".1x") or
+          (not "1X" in line and scale_factor == ".1x")):
+        continue
+
+      icon_file = open(icon_path)
+      vector_commands = "".join(icon_file.readlines())
+      icon_file.close()
+      output_cc.write("ICON_TEMPLATE({}, {})\n".format(icon_name.upper(),
+                                                       vector_commands))
   output_cc.close()
 
 
 def main():
   parser = optparse.OptionParser()
   parser.add_option("--working_directory",
                     help="The directory to look for template C++ as well as "
                          "icon files.")
   parser.add_option("--output_cc",
                     help="The path to output the CC file to.")
   parser.add_option("--output_h",
                     help="The path to output the header file to.")
 
   (options, args) = parser.parse_args()
 
   AggregateVectorIcons(options.working_directory,
                        options.output_cc,
                        options.output_h)
 
 
 if __name__ == "__main__":
   main()