Source/web/PopupMenuImpl.cpp - Issue 1270723002: Improve CSS Style matching spec compliance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/PopupMenuImpl.cpp

Issue 1270723002: Improve CSS Style matching spec compliance (Closed) Base URL: git@github.com:drott/blink-crosswalk.git@reimplementMatching

Patch Set: TODOs with bugs, redundant file removed, test expectations fix Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/PopupMenuImpl.cpp

diff --git a/Source/web/PopupMenuImpl.cpp b/Source/web/PopupMenuImpl.cpp

index 05ea02149ce9fd5dbe89ee2d1c3420a26ca28290..7085248c3103fec2c3bb9aa509fab69581945642 100644

--- a/Source/web/PopupMenuImpl.cpp

+++ b/Source/web/PopupMenuImpl.cpp

@@ -68,11 +68,15 @@ const char* fontVariantToString(FontVariant variant)

return nullptr;

}

+// TODO crbug.com/516675 Add stretch to serialization

const char* fontStyleToString(FontStyle style)

{

switch (style) {

case FontStyleNormal:

return "normal";

+ case FontStyleOblique:

+ return "oblique";

case FontStyleItalic:

return "italic";

}