Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Unified Diff: Source/core/css/CSSPrimitiveValueMappings.h

Issue 1270723002: Improve CSS Style matching spec compliance (Closed) Base URL: git@github.com:drott/blink-crosswalk.git@reimplementMatching
Patch Set: TODOs with bugs, redundant file removed, test expectations fix Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/CSSPrimitiveValueMappings.h
diff --git a/Source/core/css/CSSPrimitiveValueMappings.h b/Source/core/css/CSSPrimitiveValueMappings.h
index a8976b8fa00767dfd00e6421e09dc35c1b8ec5d4..810dd846bf19f9cc2a57ec97dad9d1a032b14c7c 100644
--- a/Source/core/css/CSSPrimitiveValueMappings.h
+++ b/Source/core/css/CSSPrimitiveValueMappings.h
@@ -3233,6 +3233,9 @@ template<> inline CSSPrimitiveValue::CSSPrimitiveValue(FontStyle italic)
case FontStyleNormal:
m_value.valueID = CSSValueNormal;
return;
+ case FontStyleOblique:
+ m_value.valueID = CSSValueOblique;
+ return;
case FontStyleItalic:
m_value.valueID = CSSValueItalic;
return;
@@ -3247,7 +3250,7 @@ template<> inline CSSPrimitiveValue::operator FontStyle() const
ASSERT(isValueID());
switch (m_value.valueID) {
case CSSValueOblique:
- // FIXME: oblique is the same as italic for the moment...
+ return FontStyleOblique;
case CSSValueItalic:
return FontStyleItalic;
case CSSValueNormal:

Powered by Google App Engine
This is Rietveld 408576698