Source/platform/fonts/win/FontCacheSkiaWin.cpp - Issue 1270723002: Improve CSS Style matching spec compliance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/win/FontCacheSkiaWin.cpp

Issue 1270723002: Improve CSS Style matching spec compliance (Closed) Base URL: git@github.com:drott/blink-crosswalk.git@reimplementMatching

Patch Set: stdlib instead of MathExtras Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/fonts/win/FontCacheSkiaWin.cpp

diff --git a/Source/platform/fonts/win/FontCacheSkiaWin.cpp b/Source/platform/fonts/win/FontCacheSkiaWin.cpp

index f6510a199b68beffef04c7a732878e85f668bb53..a77e18379649cfbc1836d8f7e09eaabf5c4ab575 100644

--- a/Source/platform/fonts/win/FontCacheSkiaWin.cpp

+++ b/Source/platform/fonts/win/FontCacheSkiaWin.cpp

@@ -372,7 +372,7 @@ FontPlatformData* FontCache::createFontPlatformData(const FontDescription& fontD

name.data(),

fontSize,

(fontDescription.weight() >= FontWeight600 && !tf->isBold()) || fontDescription.isSyntheticBold(),

- (fontDescription.style() == FontStyleItalic && !tf->isItalic()) || fontDescription.isSyntheticItalic(),

+ ((fontDescription.style() == FontStyleItalic || fontDescription.style() == FontStyleOblique) && !tf->isItalic()) || fontDescription.isSyntheticItalic(),

fontDescription.orientation(),

s_useSubpixelPositioning);

« LayoutTests/TestExpectations ('K') | « Source/platform/fonts/skia/FontCacheSkia.cpp ('k') | Source/web/PopupMenuImpl.cpp » ('j') | Source/web/PopupMenuImpl.cpp » ('J')