Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(938)

Unified Diff: chrome/android/java/res/layout/eb_search_core.xml

Issue 1270693004: Add bookmark search feature to enhanced bookmark (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address kkimlabs@'s comments Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/eb_search_core.xml
diff --git a/chrome/android/java/res/layout/eb_search_core.xml b/chrome/android/java/res/layout/eb_search_core.xml
new file mode 100644
index 0000000000000000000000000000000000000000..ad9d0346bbbc21d35202b332eccaf70fe5f3618b
--- /dev/null
+++ b/chrome/android/java/res/layout/eb_search_core.xml
@@ -0,0 +1,77 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright 2015 The Chromium Authors. All rights reserved.
+ Use of this source code is governed by a BSD-style license that can be
+ found in the LICENSE file. -->
+
+<merge xmlns:android="http://schemas.android.com/apk/res/android">
+
+ <android.support.v7.widget.Toolbar
+ android:id="@+id/search_bar"
+ android:layout_width="match_parent"
+ android:layout_height="@dimen/toolbar_height_no_shadow"
Kibeom Kim (inactive) 2015/08/12 04:26:29 ?attr/actionBarSize (suggested by go/appcompat-mat
Ian Wen 2015/08/12 18:32:40 Done. On nexus 9 this is 56dp instead of 48.
+ android:orientation="horizontal"
Kibeom Kim (inactive) 2015/08/12 04:26:29 I suppose orientation is not needed?
Ian Wen 2015/08/12 18:32:40 Done.
+ android:descendantFocusability="afterDescendants" >
Kibeom Kim (inactive) 2015/08/12 04:26:29 Is this still needed with Toolbar?
Ian Wen 2015/08/12 18:32:40 No. Removed.
+
+ <EditText
+ android:id="@+id/eb_search_text"
+ android:layout_width="match_parent"
+ android:layout_height="match_parent"
+ android:background="@null"
+ android:gravity="center_vertical"
+ android:hint="@string/enhanced_bookmark_action_bar_search"
+ android:imeOptions="flagNoExtractUi|actionSearch"
+ android:inputType="textNoSuggestions"
+ android:singleLine="true"
+ android:textColor="#343434"
+ android:textSize="20sp" />
+ </android.support.v7.widget.Toolbar>
+
+ <View
+ android:layout_width="match_parent"
+ android:layout_height="1dp"
+ android:background="#E1E1E1" />
+
+ <view class="org.chromium.chrome.browser.enhancedbookmarks.EnhancedBookmarkSearchView$HistoryResultSwitcher"
+ android:id="@+id/history_result_switcher"
+ android:layout_width="match_parent"
+ android:layout_height="match_parent"
+ android:inAnimation="@android:anim/fade_in"
+ android:outAnimation="@android:anim/fade_out" >
+
+ <ListView
+ android:id="@+id/eb_history_list"
+ android:layout_width="match_parent"
+ android:layout_height="match_parent"
+ android:divider="@null"
+ android:dividerHeight="0dp" />
+
+ <ViewSwitcher
+ android:id="@+id/result_empty_switcher"
+ android:layout_width="match_parent"
+ android:layout_height="match_parent"
+ android:inAnimation="@android:anim/fade_in"
+ android:outAnimation="@android:anim/fade_out" >
+
+ <ListView
+ android:id="@+id/eb_result_list"
+ android:layout_width="match_parent"
+ android:layout_height="match_parent"
+ android:divider="@null"
+ android:dividerHeight="0dp" />
+
+ <TextView
+ android:id="@+id/eb_search_empty_view"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:layout_gravity="center"
+ android:drawablePadding="3dp"
+ android:drawableTop="@drawable/eb_logo_large"
+ android:gravity="center"
+ android:padding="16dp"
+ android:text="@string/enhanced_bookmark_no_result"
+ android:textColor="#5B5B5B"
+ android:textSize="16sp" />
+ </ViewSwitcher>
+ </view>
+
+</merge>

Powered by Google App Engine
This is Rietveld 408576698