Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActionBar.java

Issue 1270693004: Add bookmark search feature to enhanced bookmark (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActionBar.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActionBar.java b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActionBar.java
index 190fbfbb711ac4b8e5d20420b04a9e75aa6a713b..b2694ae6a11594945a685a51c664c92cd7cbd8c3 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActionBar.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActionBar.java
@@ -85,6 +85,9 @@ public class EnhancedBookmarkActionBar extends Toolbar implements EnhancedBookma
} else if (menuItem.getItemId() == R.id.close_menu_id) {
mDelegate.finishActivityOnPhone();
return true;
+ } else if (menuItem.getItemId() == R.id.search_menu_id) {
+ mDelegate.openSearchUI();
+ return true;
} else if (menuItem.getItemId() == R.id.selection_mode_edit_menu_id) {
List<BookmarkId> list = mDelegate.getSelectedBookmarks();
assert list.size() == 1;
@@ -180,6 +183,7 @@ public class EnhancedBookmarkActionBar extends Toolbar implements EnhancedBookma
void showLoadingUi() {
setTitle(null);
setNavigationButton(NAVIGATION_BUTTON_NONE);
+ getMenu().findItem(R.id.search_menu_id).setVisible(false);
getMenu().findItem(R.id.edit_menu_id).setVisible(false);
}
@@ -202,6 +206,7 @@ public class EnhancedBookmarkActionBar extends Toolbar implements EnhancedBookma
public void onAllBookmarksStateSet() {
setTitle(R.string.enhanced_bookmark_title_bar_all_items);
setNavigationButton(NAVIGATION_BUTTON_MENU);
+ getMenu().findItem(R.id.search_menu_id).setVisible(true);
getMenu().findItem(R.id.edit_menu_id).setVisible(false);
}
@@ -209,6 +214,7 @@ public class EnhancedBookmarkActionBar extends Toolbar implements EnhancedBookma
public void onFolderStateSet(BookmarkId folder) {
mCurrentFolder = mDelegate.getModel().getBookmarkById(folder);
+ getMenu().findItem(R.id.search_menu_id).setVisible(false);
getMenu().findItem(R.id.edit_menu_id).setVisible(mCurrentFolder.isEditable());
// If the parent folder is a top level node, we don't go up anymore.

Powered by Google App Engine
This is Rietveld 408576698