Chromium Code Reviews Chromium Code Reviews
Issue 1270693004:
Add bookmark search feature to enhanced bookmark (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| (Empty) | |
| 1 <?xml version="1.0" encoding="utf-8"?> | |
| 2 <!-- Copyright 2015 The Chromium Authors. All rights reserved. | |
| 3 Use of this source code is governed by a BSD-style license that can be | |
| 4 found in the LICENSE file. --> | |
| 5 | |
| 6 <merge xmlns:android="http://schemas.android.com/apk/res/android"> | |
| 7 | |
| 8 <LinearLayout | |
|
Kibeom Kim (inactive)
2015/08/10 09:02:47
Let's use standard android.support.v7.widget.Toolb
Ian Wen
2015/08/12 00:09:26
Done. Thanks for the advice. It indeed looks nicer
| |
| 9 android:id="@+id/title_holder" | |
| 10 android:layout_width="match_parent" | |
| 11 android:layout_height="@dimen/toolbar_height_no_shadow" | |
| 12 android:orientation="horizontal" | |
| 13 android:descendantFocusability="afterDescendants" > | |
|
Kibeom Kim (inactive)
2015/08/10 09:02:47
Q: what do we need this for?
Ian Wen
2015/08/12 00:09:26
This is needed for letting the edittext get focus,
| |
| 14 | |
| 15 <ImageButton | |
| 16 android:id="@+id/eb_search_back" | |
| 17 android:layout_width="@dimen/toolbar_height_no_shadow" | |
| 18 android:layout_height="match_parent" | |
| 19 android:background="?attr/listChoiceBackgroundIndicator" | |
| 20 android:contentDescription="@string/accessibility_toolbar_btn_back" | |
| 21 android:padding="15dp" | |
| 22 android:src="@drawable/eb_back_normal" /> | |
| 23 | |
| 24 <EditText | |
| 25 android:id="@+id/eb_search_text" | |
| 26 android:layout_width="match_parent" | |
| 27 android:layout_height="match_parent" | |
| 28 android:background="@null" | |
| 29 android:gravity="center_vertical" | |
| 30 android:hint="@string/enhanced_bookmark_action_bar_search" | |
| 31 android:imeOptions="flagNoExtractUi|actionSearch" | |
| 32 android:inputType="textNoSuggestions" | |
| 33 android:singleLine="true" | |
| 34 android:textColor="#343434" | |
| 35 android:textSize="20sp" /> | |
| 36 </LinearLayout> | |
| 37 | |
| 38 <View | |
| 39 android:layout_width="match_parent" | |
| 40 android:layout_height="1dp" | |
| 41 android:background="#E1E1E1" /> | |
| 42 | |
| 43 <view class="org.chromium.chrome.browser.enhancedbookmarks.EnhancedBookmarkS earchView$HistoryResultSwitcher" | |
| 44 android:id="@+id/history_result_switcher" | |
| 45 android:layout_width="match_parent" | |
| 46 android:layout_height="match_parent" | |
| 47 android:inAnimation="@android:anim/fade_in" | |
| 48 android:outAnimation="@android:anim/fade_out" > | |
| 49 | |
| 50 <ListView | |
| 51 android:id="@+id/eb_history_list" | |
| 52 android:layout_width="match_parent" | |
| 53 android:layout_height="match_parent" | |
| 54 android:divider="@null" | |
| 55 android:dividerHeight="0dp" /> | |
| 56 | |
| 57 <ViewSwitcher | |
| 58 android:id="@+id/result_empty_switcher" | |
| 59 android:layout_width="match_parent" | |
| 60 android:layout_height="match_parent" | |
| 61 android:inAnimation="@android:anim/fade_in" | |
| 62 android:outAnimation="@android:anim/fade_out" > | |
| 63 | |
| 64 <ListView | |
| 65 android:id="@+id/eb_result_list" | |
| 66 android:layout_width="match_parent" | |
| 67 android:layout_height="match_parent" | |
| 68 android:divider="@null" | |
| 69 android:dividerHeight="0dp" /> | |
| 70 | |
| 71 <TextView | |
| 72 android:id="@+id/eb_search_empty_view" | |
| 73 android:layout_width="wrap_content" | |
| 74 android:layout_height="wrap_content" | |
| 75 android:layout_gravity="center" | |
| 76 android:drawablePadding="3dp" | |
| 77 android:drawableTop="@drawable/eb_logo_large" | |
| 78 android:gravity="center" | |
| 79 android:padding="16dp" | |
| 80 android:text="@string/enhanced_bookmark_no_result" | |
| 81 android:textColor="#5B5B5B" | |
| 82 android:textSize="16sp" /> | |
| 83 </ViewSwitcher> | |
| 84 </view> | |
| 85 | |
| 86 </merge> | |
| OLD | NEW |
