Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1270683002: ipc: Make a common subclass for Channel and ProxyChannel. (Closed)

Created:
5 years, 4 months ago by erikchen
Modified:
5 years, 4 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ipc: Make a common subclass for Channel and ProxyChannel. Channel and ProxyChannel share some functionality which the attachment broker code uses. I made a new, shared superclass called Endpoint. BUG=493414 Committed: https://crrev.com/a09b9be79387f1107ba29c5f7b0051168193d958 Cr-Commit-Position: refs/heads/master@{#342669}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : fix windodws compile error #

Patch Set 4 : Rename ProtoChannel -> Endpoint. #

Patch Set 5 : Add a missing IPC_EXPORT. #

Patch Set 6 : Fix BUILD.gn. #

Total comments: 2

Patch Set 7 : Comments from tsepez. #

Patch Set 8 : Rebase against top of tree. #

Patch Set 9 : More rebase errors. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -80 lines) Patch
M ipc/BUILD.gn View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M ipc/attachment_broker_privileged.h View 1 2 3 2 chunks +8 lines, -6 lines 0 comments Download
M ipc/attachment_broker_privileged.cc View 1 2 3 2 chunks +14 lines, -15 lines 0 comments Download
M ipc/attachment_broker_privileged_win.cc View 1 2 3 2 chunks +3 lines, -4 lines 0 comments Download
M ipc/attachment_broker_privileged_win_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ipc/attachment_broker_unprivileged.h View 1 2 3 2 chunks +2 lines, -4 lines 0 comments Download
M ipc/attachment_broker_unprivileged.cc View 1 2 3 2 chunks +5 lines, -13 lines 0 comments Download
M ipc/ipc.gypi View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M ipc/ipc_channel.h View 1 2 3 5 chunks +2 lines, -26 lines 0 comments Download
M ipc/ipc_channel_proxy.h View 1 2 3 4 5 6 7 8 4 chunks +5 lines, -6 lines 0 comments Download
M ipc/ipc_channel_proxy.cc View 1 2 3 4 5 6 7 8 3 chunks +9 lines, -5 lines 0 comments Download
A ipc/ipc_endpoint.h View 1 2 3 4 1 chunk +52 lines, -0 lines 0 comments Download
A ipc/ipc_endpoint.cc View 1 2 3 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 38 (17 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1270683002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1270683002/20001
5 years, 4 months ago (2015-07-31 01:34:41 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/86796)
5 years, 4 months ago (2015-07-31 02:11:07 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1270683002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1270683002/40001
5 years, 4 months ago (2015-07-31 02:31:23 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-07-31 04:56:03 UTC) #8
erikchen
tsepez: Please review.
5 years, 4 months ago (2015-07-31 05:06:11 UTC) #10
Tom Sepez
Can we come up with a better name than ProtoChannel? what does this really represent? ...
5 years, 4 months ago (2015-07-31 15:56:17 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1270683002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1270683002/60001
5 years, 4 months ago (2015-08-06 23:53:31 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1270683002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1270683002/80001
5 years, 4 months ago (2015-08-07 00:03:25 UTC) #15
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/100448) android_chromium_gn_compile_rel on ...
5 years, 4 months ago (2015-08-07 00:13:54 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1270683002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1270683002/100001
5 years, 4 months ago (2015-08-07 03:00:51 UTC) #19
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-07 05:16:04 UTC) #21
erikchen
tsepez: Please review. I renamed ProtoChannel to Endpoint.
5 years, 4 months ago (2015-08-07 05:53:13 UTC) #22
Tom Sepez
lgtm https://codereview.chromium.org/1270683002/diff/100001/ipc/ipc_channel_proxy.h File ipc/ipc_channel_proxy.h (right): https://codereview.chromium.org/1270683002/diff/100001/ipc/ipc_channel_proxy.h#newcode151 ipc/ipc_channel_proxy.h:151: // ProtoChannel overrides. nit: ProtoChannel
5 years, 4 months ago (2015-08-07 22:19:56 UTC) #23
erikchen
https://codereview.chromium.org/1270683002/diff/100001/ipc/ipc_channel_proxy.h File ipc/ipc_channel_proxy.h (right): https://codereview.chromium.org/1270683002/diff/100001/ipc/ipc_channel_proxy.h#newcode151 ipc/ipc_channel_proxy.h:151: // ProtoChannel overrides. On 2015/08/07 22:19:56, Tom Sepez wrote: ...
5 years, 4 months ago (2015-08-07 22:40:34 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1270683002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1270683002/120001
5 years, 4 months ago (2015-08-07 22:41:16 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/54551) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 4 months ago (2015-08-07 22:43:45 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1270683002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1270683002/160001
5 years, 4 months ago (2015-08-07 22:55:55 UTC) #32
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/90816)
5 years, 4 months ago (2015-08-08 00:45:37 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1270683002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1270683002/160001
5 years, 4 months ago (2015-08-10 18:10:50 UTC) #36
commit-bot: I haz the power
Committed patchset #9 (id:160001)
5 years, 4 months ago (2015-08-10 19:22:43 UTC) #37
commit-bot: I haz the power
5 years, 4 months ago (2015-08-10 19:23:51 UTC) #38
Message was sent while issue was closed. 
Patchset 9 (id:??) landed as
https://crrev.com/a09b9be79387f1107ba29c5f7b0051168193d958
Cr-Commit-Position: refs/heads/master@{#342669}

Powered by Google App Engine
This is Rietveld 408576698