Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1270643005: Fix repeat builds with Android. (Closed)

Created:
5 years, 4 months ago by bungeman-skia
Modified:
5 years, 4 months ago
Reviewers:
hal.canary, djsollen
CC:
reviews_skia.org, hal.canary
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix repeat builds with Android. Currently the SampleApp and VisualBench builds for Android don't work for rebuilds. The code is re-built, but the apks are not. This results from the use of a directory as 'output' and the action to build the apk not depending on the copied libraries. Committed: https://skia.googlesource.com/skia/+/15bde1697a3edb9dee683fa638d464e07e460794

Patch Set 1 #

Patch Set 2 : Also depend on libs. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M platform_tools/android/gyp/skia_android.gypi View 1 2 chunks +18 lines, -2 lines 1 comment Download

Messages

Total messages: 18 (7 generated)
bungeman-skia
I literally broke all font fallback on Android due to this. The issue makes it ...
5 years, 4 months ago (2015-07-30 21:39:59 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1270643005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1270643005/1
5 years, 4 months ago (2015-07-30 21:40:16 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-07-30 21:47:47 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1270643005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1270643005/20001
5 years, 4 months ago (2015-07-30 21:55:27 UTC) #8
bungeman-skia
5 years, 4 months ago (2015-07-30 21:58:19 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-07-30 22:02:36 UTC) #11
djsollen
lgtm
5 years, 4 months ago (2015-07-31 13:32:48 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1270643005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1270643005/20001
5 years, 4 months ago (2015-07-31 13:32:58 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/15bde1697a3edb9dee683fa638d464e07e460794
5 years, 4 months ago (2015-07-31 13:33:23 UTC) #15
hal.canary
https://codereview.chromium.org/1270643005/diff/20001/platform_tools/android/gyp/skia_android.gypi File platform_tools/android/gyp/skia_android.gypi (right): https://codereview.chromium.org/1270643005/diff/20001/platform_tools/android/gyp/skia_android.gypi#newcode99 platform_tools/android/gyp/skia_android.gypi:99: '<(android_base)/apps/sample_app/build/outputs/apk/sample_app-arm-debug.apk', arch-specific?
5 years, 4 months ago (2015-07-31 14:28:57 UTC) #17
djsollen
5 years, 4 months ago (2015-07-31 14:39:34 UTC) #18
Message was sent while issue was closed. 
good catch Hal.  I missed that.  I'll upload a new CL to fix that as I'm working
on that file now.

Powered by Google App Engine
This is Rietveld 408576698