Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 1270633004: Update NulCanvas so everything builds. (Closed)

Created:
5 years, 4 months ago by bungeman-skia
Modified:
5 years, 4 months ago
Reviewers:
hal.canary, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update NulCanvas so everything builds. SkNulCanvas.h is out of date, so the 'all' target fails. Committed: https://skia.googlesource.com/skia/+/1d58773c25873693c06e3c55e4a8591723202b54

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M experimental/PdfViewer/SkNulCanvas.h View 1 chunk +3 lines, -3 lines 0 comments Download
M experimental/PdfViewer/SkTrackDevice.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1270633004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1270633004/1
5 years, 4 months ago (2015-07-31 20:53:54 UTC) #2
bungeman-skia
Apparently we aren't building this on the bots, and it might just want to be ...
5 years, 4 months ago (2015-07-31 20:54:29 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-07-31 21:01:38 UTC) #6
djsollen
Hal can we remove this code? lgtm.
5 years, 4 months ago (2015-08-03 12:57:50 UTC) #8
hal.canary
lgtm
5 years, 4 months ago (2015-08-03 14:00:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1270633004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1270633004/1
5 years, 4 months ago (2015-08-03 14:48:58 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-03 14:56:18 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1d58773c25873693c06e3c55e4a8591723202b54

Powered by Google App Engine
This is Rietveld 408576698