Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 1270623002: Replace 'Scanning' text in Network Status Area with throbber (Closed)

Created:
5 years, 4 months ago by stevenjb
Modified:
5 years, 4 months ago
Reviewers:
jennyz
CC:
chromium-reviews, kalyank, stevenjb+watch_chromium.org, sadrul, hashimoto+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace 'Scanning' text in Network Status Area with throbber This CL: * Removes the 'Scanning' text from the network list * When scanning starts: Starts the throbber (which fades in), and fades the info button out. Clicking on the Throbber is the same as clicking on the info button. * When scanning stops: Stops the throbber (which fades out) and fades the info button in. BUG=490532 Committed: https://crrev.com/e69e9fdf1504d6119dedc7aad613aff6c27b8664 Cr-Commit-Position: refs/heads/master@{#341242}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Fix tooltips #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -52 lines) Patch
M ash/system/bluetooth/tray_bluetooth.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/network/network_state_list_detailed_view.h View 1 5 chunks +10 lines, -1 line 0 comments Download
M ash/system/chromeos/network/network_state_list_detailed_view.cc View 1 2 13 chunks +164 lines, -23 lines 0 comments Download
M ash/system/tray/special_popup_row.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/special_popup_row.cc View 1 chunk +12 lines, -14 lines 0 comments Download
M chromeos/dbus/fake_shill_manager_client.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/chromeos/network/network_list.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/chromeos/network/network_list.cc View 3 chunks +1 line, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
stevenjb
5 years, 4 months ago (2015-07-30 19:29:08 UTC) #2
jennyz
lgtm
5 years, 4 months ago (2015-07-30 23:33:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1270623002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1270623002/40001
5 years, 4 months ago (2015-07-30 23:37:14 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-07-31 00:34:01 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-07-31 00:34:51 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e69e9fdf1504d6119dedc7aad613aff6c27b8664
Cr-Commit-Position: refs/heads/master@{#341242}

Powered by Google App Engine
This is Rietveld 408576698