Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 1270603004: Add toolchains to dependency error messages in GN (Closed)

Created:
5 years, 4 months ago by brettw
Modified:
5 years, 4 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add toolchains to dependency error messages in GN This adds toolchain labels to the error message about depending on generated files if any of the toolchains are not in the default toolchain. The toolchains can be confusing (normally they're all in the default one) but for cross-toolchain dependencies, the error message becomes impossible to understand without them. Committed: https://crrev.com/58caeebf366f38af79d90b7d8dcf9dcdf7a6663b Cr-Commit-Position: refs/heads/master@{#341221}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
M tools/gn/command_gen.cc View 1 chunk +19 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
brettw
5 years, 4 months ago (2015-07-30 23:01:05 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1270603004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1270603004/1
5 years, 4 months ago (2015-07-30 23:01:15 UTC) #4
Dirk Pranke
lgtm
5 years, 4 months ago (2015-07-30 23:03:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1270603004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1270603004/1
5 years, 4 months ago (2015-07-30 23:08:14 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-30 23:14:40 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 23:15:19 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/58caeebf366f38af79d90b7d8dcf9dcdf7a6663b
Cr-Commit-Position: refs/heads/master@{#341221}

Powered by Google App Engine
This is Rietveld 408576698