src/codegen.cc - Issue 12706020: Isolatify CPU profiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/codegen.cc

Issue 12706020: Isolatify CPU profiler (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed comments Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/codegen.cc

diff --git a/src/codegen.cc b/src/codegen.cc

index 508e221eb32deeeb9398de6910ce546dc604971e..90ab2b5a209713bd51eb7f26fc9c934dc06e4ae9 100644

--- a/src/codegen.cc

+++ b/src/codegen.cc

@@ -171,7 +171,8 @@ void CodeGenerator::PrintCode(Handle<Code> code, CompilationInfo* info) {

bool CodeGenerator::ShouldGenerateLog(Expression* type) {

ASSERT(type != NULL);

Isolate* isolate = Isolate::Current();

- if (!isolate->logger()->is_logging() && !CpuProfiler::is_profiling(isolate)) {

+ if (!isolate->logger()->is_logging() &&

+ !isolate->cpu_profiler()->is_profiling()) {

return false;

}

Handle<String> name = Handle<String>::cast(type->AsLiteral()->handle());

« no previous file with comments | « src/api.cc ('k') | src/compiler.cc » ('j') | no next file with comments »