Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1492)

Issue 12706005: drive: Introduce kInitialChangestamp to DriveResourceMetadataTest (Closed)

Created:
7 years, 9 months ago by satorux1
Modified:
7 years, 9 months ago
Reviewers:
hashimoto
CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

drive: Introduce kInitialChangestamp to DriveResourceMetadataTest This is in preparation for adding tests that check the per-directory changestamp to be zero, for newly added directories by RefreshDirectory(). In other words, we need to distinguish zero from the initial changestamp. BUG=178348 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187505

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -16 lines) Patch
M chrome/browser/chromeos/drive/drive_resource_metadata_unittest.cc View 1 14 chunks +38 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
satorux1
7 years, 9 months ago (2013-03-12 05:00:05 UTC) #1
hashimoto
lgtm with a nit https://codereview.chromium.org/12706005/diff/1/chrome/browser/chromeos/drive/drive_resource_metadata_unittest.cc File chrome/browser/chromeos/drive/drive_resource_metadata_unittest.cc (right): https://codereview.chromium.org/12706005/diff/1/chrome/browser/chromeos/drive/drive_resource_metadata_unittest.cc#newcode35 chrome/browser/chromeos/drive/drive_resource_metadata_unittest.cc:35: const int64 kInitialChangestamp = 100; ...
7 years, 9 months ago (2013-03-12 05:07:54 UTC) #2
satorux1
https://codereview.chromium.org/12706005/diff/1/chrome/browser/chromeos/drive/drive_resource_metadata_unittest.cc File chrome/browser/chromeos/drive/drive_resource_metadata_unittest.cc (right): https://codereview.chromium.org/12706005/diff/1/chrome/browser/chromeos/drive/drive_resource_metadata_unittest.cc#newcode35 chrome/browser/chromeos/drive/drive_resource_metadata_unittest.cc:35: const int64 kInitialChangestamp = 100; On 2013/03/12 05:07:54, hashimoto ...
7 years, 9 months ago (2013-03-12 05:12:00 UTC) #3
hashimoto
lgtm Please update change description before commit
7 years, 9 months ago (2013-03-12 05:17:51 UTC) #4
satorux1
Committed patchset #2 manually as r187505 (presubmit successful).
7 years, 9 months ago (2013-03-12 05:18:38 UTC) #5
satorux1
7 years, 9 months ago (2013-03-12 05:19:07 UTC) #6
Message was sent while issue was closed.
oops. sorry, too late. shouldn't be a big issue...

Powered by Google App Engine
This is Rietveld 408576698