Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 1270573003: find image whenever we generateGlyph (Closed)

Created:
5 years, 4 months ago by joshua.litt
Modified:
5 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

find image whenever we generateGlyph. This should ensure the glyph is fully initialized before we start using the maskformat. BUG=skia: Committed: https://skia.googlesource.com/skia/+/381b26f03bdccac1e3d9055fb4f7855792cfefb0

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M src/gpu/GrFontScaler.cpp View 1 chunk +10 lines, -0 lines 1 comment Download

Messages

Total messages: 8 (3 generated)
joshualitt
ptal, on desktop this doesnt seem to effect performance.
5 years, 4 months ago (2015-07-30 19:18:13 UTC) #3
jvanverth1
https://codereview.chromium.org/1270573003/diff/1/src/gpu/GrFontScaler.cpp File src/gpu/GrFontScaler.cpp (right): https://codereview.chromium.org/1270573003/diff/1/src/gpu/GrFontScaler.cpp#newcode78 src/gpu/GrFontScaler.cpp:78: #if 1 Once we get into this routine isn't ...
5 years, 4 months ago (2015-07-30 19:28:24 UTC) #4
jvanverth1
On 2015/07/30 19:28:24, jvanverth1 wrote: > https://codereview.chromium.org/1270573003/diff/1/src/gpu/GrFontScaler.cpp > File src/gpu/GrFontScaler.cpp (right): > > https://codereview.chromium.org/1270573003/diff/1/src/gpu/GrFontScaler.cpp#newcode78 > ...
5 years, 4 months ago (2015-07-30 19:34:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1270573003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1270573003/1
5 years, 4 months ago (2015-07-30 19:36:01 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 19:43:19 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/381b26f03bdccac1e3d9055fb4f7855792cfefb0

Powered by Google App Engine
This is Rietveld 408576698