Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Unified Diff: ash/wm/drag_window_resizer.cc

Issue 127053005: Cleanup: remove Details::window. Use GetTarget() when possible (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/drag_window_resizer.cc
diff --git a/ash/wm/drag_window_resizer.cc b/ash/wm/drag_window_resizer.cc
index 2a859cff359b52f3aa0f699de7e1ecbef50d13be..6c38f0933aae3edf6753a78569320cef7d1d899a 100644
--- a/ash/wm/drag_window_resizer.cc
+++ b/ash/wm/drag_window_resizer.cc
@@ -185,7 +185,7 @@ DragWindowResizer::DragWindowResizer(WindowResizer* next_window_resizer,
MouseCursorEventFilter::WARP_DRAG : MouseCursorEventFilter::WARP_NONE);
if (ShouldAllowMouseWarp()) {
mouse_cursor_filter->ShowSharedEdgeIndicator(
- details.window->GetRootWindow());
+ details.window()->GetRootWindow());
varkha 2014/01/08 23:46:56 Would GetTarget() be more consistent?
}
instance_ = this;
}
@@ -254,7 +254,7 @@ TrayUser* DragWindowResizer::GetTrayUserItemAtPoint(
// We only allow to drag the window onto a tray of it's own RootWindow.
SystemTray* tray = internal::GetRootWindowController(
- details_.window->GetRootWindow())->GetSystemTray();
+ details_.window()->GetRootWindow())->GetSystemTray();
varkha 2014/01/08 23:46:56 I think GetTarget() here would be more consistent.
// Again - unit tests might not have a tray.
if (!tray)
@@ -286,7 +286,7 @@ bool DragWindowResizer::TryDraggingToNewUser() {
int old_opacity = GetTarget()->layer()->opacity();
GetTarget()->layer()->SetOpacity(0);
GetTarget()->SetBounds(details_.initial_bounds_in_parent);
- if (!tray_user->TransferWindowToUser(details_.window)) {
+ if (!tray_user->TransferWindowToUser(details_.window())) {
varkha 2014/01/08 23:46:56 Ditto here.
GetTarget()->layer()->SetOpacity(old_opacity);
return false;
}

Powered by Google App Engine
This is Rietveld 408576698