[cc] Unify static create method of ResourceUpdate

[cc] Unify static create method of ResourceUpdate

Remove ResourceUpdate::CreateFromCanvas().
|canvas| member variable of ResourceUpdate is not used by ResourceUpdateController.
Also all customer of ResourceUpdate can pass SkBitmap.

R=enne@chromium.org, danakj@chromium.org
BUG=NONE
TEST=cc_unittests --gtest_filter=ResourceUpdateControllerTest.*

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243856

[simonhong, 2014-01-08 07:05:55]

PTAL!

[danakj, 2014-01-08 17:49:59]

This looks fine, though we're really just working on deleting this code rather
than tweak it at this point.

https://codereview.chromium.org/127053004/diff/1/cc/resources/bitmap_content_...
File cc/resources/bitmap_content_layer_updater.cc (right):

https://codereview.chromium.org/127053004/diff/1/cc/resources/bitmap_content_...
cc/resources/bitmap_content_layer_updater.cc:1: // Copyright 2014 The Chromium
Authors. All rights reserved.
We don't update the year in files. We only use the current year in new files.

https://codereview.chromium.org/127053004/diff/1/cc/resources/resource_update.h
File cc/resources/resource_update.h (right):

https://codereview.chromium.org/127053004/diff/1/cc/resources/resource_update...
cc/resources/resource_update.h:22: static ResourceUpdate
Create(PrioritizedResource* texture,
They should both be named resource rather than both be named texture, really.

[enne (OOO), 2014-01-08 17:51:45]

https://codereview.chromium.org/127053004/diff/1/cc/resources/bitmap_content_...
File cc/resources/bitmap_content_layer_updater.cc (left):

https://codereview.chromium.org/127053004/diff/1/cc/resources/bitmap_content_...
cc/resources/bitmap_content_layer_updater.cc:95:
ResourceUpdate::CreateFromCanvas(texture,
Can this function be removed now along with the canvas parameter on
ResourceUpdate?

https://codereview.chromium.org/127053004/diff/1/cc/resources/bitmap_content_...
File cc/resources/bitmap_content_layer_updater.cc (right):

https://codereview.chromium.org/127053004/diff/1/cc/resources/bitmap_content_...
cc/resources/bitmap_content_layer_updater.cc:1: // Copyright 2014 The Chromium
Authors. All rights reserved.
Don't update copyright.

https://codereview.chromium.org/127053004/diff/1/cc/resources/resource_update.h
File cc/resources/resource_update.h (right):

https://codereview.chromium.org/127053004/diff/1/cc/resources/resource_update...
cc/resources/resource_update.h:22: static ResourceUpdate
Create(PrioritizedResource* texture,
Nope.  resource != texture.  We call this a texture elsewhere, but it should be
a resource.

https://codereview.chromium.org/127053004/diff/1/cc/resources/skpicture_conte...
File cc/resources/skpicture_content_layer_updater.h (right):

https://codereview.chromium.org/127053004/diff/1/cc/resources/skpicture_conte...
cc/resources/skpicture_content_layer_updater.h:17: // This class records the
content_rect into an SkPicture. Subclass provides
This looks unrelated to your change description.  Can you stick it in another
patch?

[simonhong, 2014-01-09 04:36:25]

Dear enne and danakj,
Thank you for kind review.
Please check again.

danakj@, would you tell more about code deleting progress you mentioned in
previous review comment?
If I can, I want to help that work.

https://codereview.chromium.org/127053004/diff/1/cc/resources/bitmap_content_...
File cc/resources/bitmap_content_layer_updater.cc (left):

https://codereview.chromium.org/127053004/diff/1/cc/resources/bitmap_content_...
cc/resources/bitmap_content_layer_updater.cc:95:
ResourceUpdate::CreateFromCanvas(texture,
On 2014/01/08 17:51:45, enne wrote:
> Can this function be removed now along with the canvas parameter on
> ResourceUpdate?

I already removed ResourceUpdate::CreateFromCanvas() in this CL :).

https://codereview.chromium.org/127053004/diff/1/cc/resources/bitmap_content_...
File cc/resources/bitmap_content_layer_updater.cc (right):

https://codereview.chromium.org/127053004/diff/1/cc/resources/bitmap_content_...
cc/resources/bitmap_content_layer_updater.cc:1: // Copyright 2014 The Chromium
Authors. All rights reserved.
On 2014/01/08 17:51:45, enne wrote:
> Don't update copyright.

Done.

https://codereview.chromium.org/127053004/diff/1/cc/resources/resource_update.h
File cc/resources/resource_update.h (right):

https://codereview.chromium.org/127053004/diff/1/cc/resources/resource_update...
cc/resources/resource_update.h:22: static ResourceUpdate
Create(PrioritizedResource* texture,
On 2014/01/08 17:51:45, enne wrote:
> Nope.  resource != texture.  We call this a texture elsewhere, but it should
be
> a resource.

Done.

https://codereview.chromium.org/127053004/diff/1/cc/resources/skpicture_conte...
File cc/resources/skpicture_content_layer_updater.h (right):

https://codereview.chromium.org/127053004/diff/1/cc/resources/skpicture_conte...
cc/resources/skpicture_content_layer_updater.h:17: // This class records the
content_rect into an SkPicture. Subclass provides
On 2014/01/08 17:51:45, enne wrote:
> This looks unrelated to your change description.  Can you stick it in another
> patch?

Removed and sent out another cl.

https://codereview.chromium.org/127053004/diff/80001/cc/resources/resource_up...
File cc/resources/resource_update.cc (right):

https://codereview.chromium.org/127053004/diff/80001/cc/resources/resource_up...
cc/resources/resource_update.cc:13: ResourceUpdate
ResourceUpdate::Create(PrioritizedResource* resource,
Changed to resource, too.

[enne (OOO), 2014-01-09 07:07:00]

lgtm

[commit-bot: I haz the power, 2014-01-09 07:07:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/simonhong@chromium.org/127053004/110002

[commit-bot: I haz the power, 2014-01-09 12:02:24]

Change committed as 243856

[danakj, 2014-01-09 18:29:10]

On Wed, Jan 8, 2014 at 11:36 PM, <simonhong@chromium.org> wrote:

> Dear enne and danakj,
> Thank you for kind review.
> Please check again.
>
> danakj@, would you tell more about code deleting progress you mentioned in
> previous review comment?
> If I can, I want to help that work.


This code is part of the TiledLayer/PrioritizedResourceManager code path.
We're replacing this with impl-side painting everywhere, which uses
PictureLayer and TileManager/RasterWorkerPool etc.
http://www.chromium.org/developers/design-documents/impl-side-painting

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.