content/common/service_worker/service_worker_types.cc - Issue 1270513002: Service Worker: Make ServiceWorkerRegistration.update() return a promise. (Chromium 2/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/service_worker/service_worker_types.cc

Issue 1270513002: Service Worker: Make ServiceWorkerRegistration.update() return a promise. (Chromium 2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Pass a raw ptr to callback's onError instead of a scoped_ptr. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/common/service_worker/service_worker_types.cc

diff --git a/content/common/service_worker/service_worker_types.cc b/content/common/service_worker/service_worker_types.cc

index 39f84054b70dc5628f644645000f917143cc9265..5204688ca25670dcf5cd289c57f509aa8833d721 100644

--- a/content/common/service_worker/service_worker_types.cc

+++ b/content/common/service_worker/service_worker_types.cc

@@ -8,6 +8,8 @@ namespace content {

const char kServiceWorkerRegisterErrorPrefix[] =

"Failed to register a ServiceWorker: ";

+const char kServiceWorkerUpdateErrorPrefix[] =

+ "Failed to update a ServiceWorker: ";

const char kServiceWorkerUnregisterErrorPrefix[] =

"Failed to unregister a ServiceWorkerRegistration: ";

const char kServiceWorkerGetRegistrationErrorPrefix[] =

« no previous file with comments | « content/common/service_worker/service_worker_types.h ('k') | no next file » | no next file with comments »