content/browser/service_worker/service_worker_dispatcher_host.h - Issue 1270513002: Service Worker: Make ServiceWorkerRegistration.update() return a promise. (Chromium 2/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_dispatcher_host.h

Issue 1270513002: Service Worker: Make ServiceWorkerRegistration.update() return a promise. (Chromium 2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Pass a raw ptr to callback's onError instead of a scoped_ptr. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_context_core.cc ('k') | content/browser/service_worker/service_worker_dispatcher_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_dispatcher_host.h

diff --git a/content/browser/service_worker/service_worker_dispatcher_host.h b/content/browser/service_worker/service_worker_dispatcher_host.h

index c2e5c25b3e74027a2afceed88c14745ab54d3565..2635494a971c13387dcfb31a5a6b6a7b008b4bd7 100644

--- a/content/browser/service_worker/service_worker_dispatcher_host.h

+++ b/content/browser/service_worker/service_worker_dispatcher_host.h

@@ -88,7 +88,10 @@ class CONTENT_EXPORT ServiceWorkerDispatcherHost : public BrowserMessageFilter {

int provider_id,

const GURL& pattern,

const GURL& script_url);

- void OnUpdateServiceWorker(int provider_id, int64 registration_id);

+ void OnUpdateServiceWorker(int thread_id,

+ int request_id,

+ int provider_id,

+ int64 registration_id);

void OnUnregisterServiceWorker(int thread_id,

int request_id,

int provider_id,

@@ -151,6 +154,13 @@ class CONTENT_EXPORT ServiceWorkerDispatcherHost : public BrowserMessageFilter {

const std::string& status_message,

int64 registration_id);

+ void UpdateComplete(int thread_id,

+ int provider_id,

+ int request_id,

+ ServiceWorkerStatusCode status,

+ const std::string& status_message,

+ int64 registration_id);

void UnregistrationComplete(int thread_id,

int request_id,

ServiceWorkerStatusCode status);