Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Unified Diff: content/browser/service_worker/service_worker_register_job.h

Issue 1270513002: Service Worker: Make ServiceWorkerRegistration.update() return a promise. (Chromium 2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix strings. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_register_job.h
diff --git a/content/browser/service_worker/service_worker_register_job.h b/content/browser/service_worker/service_worker_register_job.h
index 537ac4cbae112effc6a3c308334d2ffae33de9d0..124cefdf45dbd6aba4725c7f52f649d8832fe5cb 100644
--- a/content/browser/service_worker/service_worker_register_job.h
+++ b/content/browser/service_worker/service_worker_register_job.h
@@ -55,8 +55,8 @@ class ServiceWorkerRegisterJob : public ServiceWorkerRegisterJobBase {
// Registers a callback to be called when the promise would resolve (whether
// successfully or not). Multiple callbacks may be registered.
- // If |provider_host| is not NULL, its process will be regarded as a candidate
- // process to run the worker.
+ // If |provider_host| is not NULL, its process will be regarded as a
+ // candidate process to run the worker.
nhiroki 2015/07/31 06:49:11 nit: This change looks not necessary.
jungkees 2015/07/31 07:09:58 Yes, right. This was changed when I tried to make
void AddCallback(const RegistrationCallback& callback,
ServiceWorkerProviderHost* provider_host);

Powered by Google App Engine
This is Rietveld 408576698