Service Worker: Make ServiceWorkerRegistration.update() return a promise. (Chromium 2/3)

content/browser/service_worker/service_worker_register_job.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_REGISTER_JOB_H_
 #define CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_REGISTER_JOB_H_
 
 #include <vector>
 
 #include "base/memory/weak_ptr.h"
@@ skipping 37 matching lines @@
 
   // For update jobs.
   CONTENT_EXPORT ServiceWorkerRegisterJob(
       base::WeakPtr<ServiceWorkerContextCore> context,
       ServiceWorkerRegistration* registration,
       bool force_bypass_cache);
   ~ServiceWorkerRegisterJob() override;
 
   // Registers a callback to be called when the promise would resolve (whether
   // successfully or not). Multiple callbacks may be registered.
-  // If |provider_host| is not NULL, its process will be regarded as a candidate
-  // process to run the worker.
+  // If |provider_host| is not NULL, its process will be regarded as a
+  // candidate process to run the worker.

[nhiroki, 2015/07/31 06:49:11]

nit: This change looks not necessary.

[jungkees, 2015/07/31 07:09:58]

Yes, right. This was changed when I tried to make |provider_host| to
|opt_provider_host| but I rather have done it by overloading the functions after
all. I'll leave the original comment as-is.

   void AddCallback(const RegistrationCallback& callback,
                    ServiceWorkerProviderHost* provider_host);
 
   // ServiceWorkerRegisterJobBase implementation:
   void Start() override;
   void Abort() override;
   bool Equals(ServiceWorkerRegisterJobBase* job) const override;
   RegistrationJobType GetType() const override;
 
   void DoomInstallingWorker();
@@ skipping 84 matching lines @@
   std::string promise_resolved_status_message_;
   scoped_refptr<ServiceWorkerRegistration> promise_resolved_registration_;
   base::WeakPtrFactory<ServiceWorkerRegisterJob> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ServiceWorkerRegisterJob);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_REGISTER_JOB_H_