Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1270443006: Proof-read comments in src/url/. (Closed)

Created:
5 years, 4 months ago by qyearsley
Modified:
5 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Proof-read comments in src/url/. Committed: https://crrev.com/2bc727de36df5826011630b13e1ae86f349f1486 Cr-Commit-Position: refs/heads/master@{#343473}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -145 lines) Patch
M url/gurl.h View 6 chunks +9 lines, -10 lines 1 comment Download
M url/gurl.cc View 4 chunks +9 lines, -8 lines 0 comments Download
M url/gurl_unittest.cc View 7 chunks +11 lines, -10 lines 0 comments Download
M url/origin.h View 1 chunk +1 line, -1 line 0 comments Download
M url/url_canon.h View 9 chunks +13 lines, -13 lines 0 comments Download
M url/url_canon_etc.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M url/url_canon_host.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M url/url_canon_internal.h View 6 chunks +6 lines, -6 lines 0 comments Download
M url/url_canon_internal.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M url/url_canon_internal_file.h View 1 chunk +3 lines, -3 lines 0 comments Download
M url/url_canon_ip.h View 1 chunk +6 lines, -6 lines 0 comments Download
M url/url_canon_ip.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M url/url_canon_mailtourl.cc View 1 chunk +1 line, -1 line 0 comments Download
M url/url_canon_path.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M url/url_canon_pathurl.cc View 1 chunk +1 line, -1 line 0 comments Download
M url/url_canon_query.cc View 1 chunk +1 line, -1 line 0 comments Download
M url/url_canon_relative.cc View 6 chunks +10 lines, -10 lines 0 comments Download
M url/url_canon_stdurl.cc View 1 chunk +1 line, -1 line 0 comments Download
M url/url_canon_unittest.cc View 17 chunks +27 lines, -26 lines 0 comments Download
M url/url_parse_internal.h View 1 chunk +1 line, -1 line 0 comments Download
M url/url_parse_unittest.cc View 9 chunks +10 lines, -10 lines 0 comments Download
M url/url_test_utils.h View 3 chunks +3 lines, -3 lines 0 comments Download
M url/url_util.h View 2 chunks +2 lines, -2 lines 0 comments Download
M url/url_util.cc View 7 chunks +9 lines, -8 lines 0 comments Download
M url/url_util_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
qyearsley
This CL is supposed to contain spelling/style changes to comments only. https://codereview.chromium.org/1270443006/diff/1/url/gurl.h File url/gurl.h (right): ...
5 years, 4 months ago (2015-08-04 22:16:44 UTC) #2
qyearsley
Ping, in case this CL slipped through. This CL is not urgent though since it's ...
5 years, 4 months ago (2015-08-14 00:57:14 UTC) #3
brettw
Oh, sorry. I started looking at it, got sidetracked, and then it was marked as ...
5 years, 4 months ago (2015-08-14 04:30:19 UTC) #4
brettw
lgtm
5 years, 4 months ago (2015-08-14 17:25:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1270443006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1270443006/1
5 years, 4 months ago (2015-08-14 17:42:34 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-14 20:17:22 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-14 20:17:55 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2bc727de36df5826011630b13e1ae86f349f1486
Cr-Commit-Position: refs/heads/master@{#343473}

Powered by Google App Engine
This is Rietveld 408576698