Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Issue 1270423006: Revert of Added Signin Utilities (Closed)

Created:
5 years, 4 months ago by Michael van Ouwerkerk
Modified:
5 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Added Signin Utilities (patchset #21 id:390001 of https://codereview.chromium.org/1258563005/ ) Reason for revert: Tests are failing: https://code.google.com/p/chromium/issues/detail?id=517849 Original issue's description: > Tools for being able to sign into fake OS accounts and fake app accounts > when running tests. Real OS accounts are also supported, but take > significantly longer because accounts must be authenticated. It is > recommended to use fake OS accounts unless real ones are necessary. > > CQ-DEPEND=CL:1259253007 > > Committed: https://crrev.com/6832765af577d32c774763e5abe8486aa8db7478 > Cr-Commit-Position: refs/heads/master@{#342190} TBR=mikecase@chromium.org,jbudorick@chromium.org,yfriedman@chromium.org,skirmani@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/ff13864f73ac781d885f68f98dd8c7a63d384675 Cr-Commit-Position: refs/heads/master@{#342333}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -373 lines) Patch
D chrome/android/javatests/src/org/chromium/chrome/test/util/ChromeSigninUtilsTest.java View 1 chunk +0 lines, -144 lines 0 comments Download
D chrome/test/android/javatests/src/org/chromium/chrome/test/util/ChromeSigninUtils.java View 1 chunk +0 lines, -229 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael van Ouwerkerk
Created Revert of Added Signin Utilities
5 years, 4 months ago (2015-08-07 11:06:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1270423006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1270423006/1
5 years, 4 months ago (2015-08-07 11:06:48 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-07 11:07:13 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 11:07:49 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ff13864f73ac781d885f68f98dd8c7a63d384675
Cr-Commit-Position: refs/heads/master@{#342333}

Powered by Google App Engine
This is Rietveld 408576698