Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1270423003: [strong] dot prototypes of strong class literals should be strong objects (Closed)

Created:
5 years, 4 months ago by conradw
Modified:
5 years, 4 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[strong] dot prototypes of strong class literals should be strong objects BUG=v8:3956 LOG=N Committed: https://crrev.com/24e1bcbfeaa5f71e678841d2e247300b95e67d47 Cr-Commit-Position: refs/heads/master@{#30032}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M src/runtime/runtime-classes.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M test/mjsunit/strong/literals.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
conradw
5 years, 4 months ago (2015-08-05 15:17:56 UTC) #2
conradw
On 2015/08/05 15:17:56, conradw wrote: oops, PTAL
5 years, 4 months ago (2015-08-05 15:18:14 UTC) #3
rossberg
lgtm
5 years, 4 months ago (2015-08-05 15:34:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1270423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1270423003/1
5 years, 4 months ago (2015-08-05 15:35:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-05 15:37:02 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-05 15:38:16 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/24e1bcbfeaa5f71e678841d2e247300b95e67d47
Cr-Commit-Position: refs/heads/master@{#30032}

Powered by Google App Engine
This is Rietveld 408576698