Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1270403006: This iOS crash makes little sense to me. Add some debugging. (Closed)

Created:
5 years, 4 months ago by mtklein_C
Modified:
5 years, 4 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

This iOS crash makes little sense to me. Add some debugging. We called new float[...]. The pointer returned should be aligned for float writes. See https://uberchromegw.corp.google.com/i/client.skia/builders/Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Release BUG=skia: Committed: https://skia.googlesource.com/skia/+/30e4d75c3aebf49b179c265a91adbb6012970d2b Committed: https://skia.googlesource.com/skia/+/f1595185e3855580b881c3d9c05344695d019030 COMMIT=false

Patch Set 1 #

Patch Set 2 : Flail a bit. Still doesn't make any sense. #

Patch Set 3 : print more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/gpu/GrTestUtils.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M tools/flags/SkCommonFlags.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
mtklein
lgtm
5 years, 4 months ago (2015-08-07 13:30:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1270403006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1270403006/1
5 years, 4 months ago (2015-08-07 13:30:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1270403006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1270403006/1
5 years, 4 months ago (2015-08-07 13:54:59 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/30e4d75c3aebf49b179c265a91adbb6012970d2b
5 years, 4 months ago (2015-08-07 13:55:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1270403006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1270403006/20001
5 years, 4 months ago (2015-08-07 14:15:10 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/f1595185e3855580b881c3d9c05344695d019030
5 years, 4 months ago (2015-08-07 14:22:47 UTC) #12
Stephen White
5 years, 4 months ago (2015-08-07 14:28:30 UTC) #13
Message was sent while issue was closed. 
On 2015/08/07 14:22:47, commit-bot: I haz the power wrote:
> Committed patchset #2 (id:20001) as
> https://skia.googlesource.com/skia/+/f1595185e3855580b881c3d9c05344695d019030

Thanks for looking into this! I couldn't make sense of it either.

Powered by Google App Engine
This is Rietveld 408576698