Simple PMP reader to parse Picasa's metadata

webkit/fileapi/media/picasa/pmp_table_reader.cc

Index: webkit/fileapi/media/picasa/pmp_table_reader.cc
diff --git a/webkit/fileapi/media/picasa/pmp_table_reader.cc b/webkit/fileapi/media/picasa/pmp_table_reader.cc
new file mode 100644
index 0000000000000000000000000000000000000000..af50530f883454f6028e62a0e82baa2f1c2a9458
--- /dev/null
+++ b/webkit/fileapi/media/picasa/pmp_table_reader.cc
@@ -0,0 +1,98 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "webkit/fileapi/media/picasa/pmp_table_reader.h"
+
+#include <algorithm>
+
+#include "base/file_util.h"
+#include "base/files/file_path.h"
+#include "base/logging.h"
+#include "base/utf_string_conversions.h"
+#include "webkit/fileapi/media/picasa/pmp_column_reader.h"
+#include "webkit/fileapi/media/picasa/pmp_constants.h"
+
+namespace picasaimport {
+
+namespace {
+
+COMPILE_ASSERT(sizeof(double) == 8, double_must_be_8_bytes_long);
+
+}  // namespace
+
+PmpTableReader::PmpTableReader() : column_readers_(), max_row_count_(0) { }
+
+PmpTableReader::~PmpTableReader() { }
+
+bool PmpTableReader::Init(const std::string& table_name,
+                          const base::FilePath& directory_path,
+                          const std::vector<std::string>& columns) {
+  DCHECK(!columns.empty());
+
+  if (!column_readers_.empty())
+    return false;
+
+  if (!file_util::DirectoryExists(directory_path))
+    return false;
+
+  std::string table_prefix = table_name + "_";
+  std::string indicator_file_name = table_prefix + "0";
+
+#if defined(OS_WIN)
+  base::FilePath indicator_file = directory_path.Append(
+      UTF8ToUTF16(indicator_file_name));
+#else
+  base::FilePath indicator_file =
+      directory_path.Append(indicator_file_name);
+#endif

[kinuko, 2013/04/10 02:27:54]

Could we replace these ifdefs with FilePath::FromUTF8Unsafe like following? Or
do we specifically want to use UTF8ToUTF16? (Which does slightly different
thing)

directory_path.Append(FilePath::FromUTF8Unsafe(indicator_file_name));

[tommycli, 2013/04/10 18:32:42]

Actually I believe semantically speaking, FromUTF8Unsafe is exactly what we
want. Good catch!

+
+  // Look for the indicator_file file, indicating table existence.
+  if (!file_util::PathExists(indicator_file) ||
+      file_util::DirectoryExists(indicator_file)) {
+    return false;
+  }
+
+  ScopedVector<PmpColumnReader> column_readers;
+  uint32 max_row_count = 0;
+
+  for (std::vector<std::string>::const_iterator it = columns.begin();
+       it != columns.end(); ++it) {
+    std::string filename = table_prefix + *it + "." + kPmpExtension;
+
+#if defined(OS_WIN)
+    base::FilePath column_file_path = directory_path.Append(
+        UTF8ToUTF16(filename));
+#else
+    base::FilePath column_file_path = directory_path.Append(filename);
+#endif
+
+
+    PmpColumnReader* column_reader = new PmpColumnReader();
+    column_readers.push_back(column_reader);
+
+    uint32 row_cnt;
+
+    if (!column_reader->Init(column_file_path, &row_cnt))
+      return false;
+
+    max_row_count = std::max(max_row_count, row_cnt);
+  }
+
+  column_readers_ = column_readers.Pass();
+  max_row_count_ = max_row_count;
+
+  return true;
+}
+
+uint32 PmpTableReader::RowCount() const {
+  return max_row_count_;
+}
+
+std::vector<const PmpColumnReader*> PmpTableReader::GetColumns() const {
+  std::vector<const PmpColumnReader*> readers(
+      column_readers_.begin(), column_readers_.end());
+  return readers;
+}
+
+}  // namespace picasaimport