Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 12704006: [Telemetry] Use 127.0.0.1 instead of localhost for TemporaryHTTPServer. (Closed)

Created:
7 years, 9 months ago by tonyg
Modified:
7 years, 9 months ago
Reviewers:
dtu
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Visibility:
Public.

Description

[Telemetry] Use 127.0.0.1 instead of localhost for TemporaryHTTPServer. On Windows 7, localhost is extremely slow. This simple change brings the moz page cycler cycle time down from 1714ms to 122ms! That restores it to roughly the level it was at prior to the shift to Telemetry. BUG=196411 TEST=python tools\perf\run_multipage_benchmarks --browser=system page_cycler tools\perf\page_sets\page_cycler\moz.json TBR=dtu@chromium.org NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189043

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/telemetry/telemetry/core/chrome/desktop_browser_backend.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
tonyg
Committed patchset #1 manually as r189043 (presubmit successful).
7 years, 9 months ago (2013-03-19 16:49:56 UTC) #1
dtu
Interesting... Why does that work!?! There are a bunch of other uses of localhost in ...
7 years, 9 months ago (2013-03-19 16:54:40 UTC) #2
tonyg
On 2013/03/19 16:54:40, Dave Tu wrote: > Interesting... Why does that work!?! There are a ...
7 years, 9 months ago (2013-03-19 17:05:15 UTC) #3
nduca
7 years, 9 months ago (2013-03-19 18:31:15 UTC) #4
Message was sent while issue was closed.
holy cow

Powered by Google App Engine
This is Rietveld 408576698