src/compiler/linkage.cc - Issue 1270393002: [strong] Refactor out separate strong runtime call for class objects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/linkage.cc

Issue 1270393002: [strong] Refactor out separate strong runtime call for class objects (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: cl feedback Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/linkage.cc

diff --git a/src/compiler/linkage.cc b/src/compiler/linkage.cc

index bae73df9f499134f8f2514c339521e85920e3137..5421f4110f0645b2ffadd0b6f350910fc49b9f46 100644

--- a/src/compiler/linkage.cc

+++ b/src/compiler/linkage.cc

@@ -193,7 +193,6 @@ int Linkage::FrameStateInputCount(Runtime::FunctionId function) {

case Runtime::kAllocateInTargetSpace:

case Runtime::kDateField:

case Runtime::kFinalizeClassDefinition: // TODO(conradw): Is it safe?

- case Runtime::kFinalizeClassDefinitionStrong: // TODO(conradw): Is it safe?

case Runtime::kDefineClassMethod: // TODO(jarin): Is it safe?

case Runtime::kDefineGetterPropertyUnchecked: // TODO(jarin): Is it safe?

case Runtime::kDefineSetterPropertyUnchecked: // TODO(jarin): Is it safe?

« no previous file with comments | « src/compiler/ast-graph-builder.cc ('k') | src/full-codegen/arm/full-codegen-arm.cc » ('j') | no next file with comments »