Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 1270323002: Revert VM thread cleanup (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart.cc ('k') | runtime/vm/debugger_api_impl_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_api_impl.cc
diff --git a/runtime/vm/dart_api_impl.cc b/runtime/vm/dart_api_impl.cc
index d434d47a181495016a68bed005cfde5823c2f003..038bfc85e64e7425fde0e191965309f23fc756ca 100644
--- a/runtime/vm/dart_api_impl.cc
+++ b/runtime/vm/dart_api_impl.cc
@@ -1263,7 +1263,7 @@ DART_EXPORT const char* Dart_VersionString() {
return Version::String();
}
-DART_EXPORT char* Dart_Initialize(
+DART_EXPORT bool Dart_Initialize(
const uint8_t* vm_isolate_snapshot,
Dart_IsolateCreateCallback create,
Dart_IsolateInterruptCallback interrupt,
@@ -1279,19 +1279,21 @@ DART_EXPORT char* Dart_Initialize(
file_open, file_read, file_write,
file_close, entropy_source);
if (err_msg != NULL) {
- return strdup(err_msg);
+ OS::PrintErr("Dart_Initialize: %s\n", err_msg);
+ return false;
}
- return NULL;
+ return true;
}
-DART_EXPORT char* Dart_Cleanup() {
+DART_EXPORT bool Dart_Cleanup() {
CHECK_NO_ISOLATE(Isolate::Current());
const char* err_msg = Dart::Cleanup();
if (err_msg != NULL) {
- return strdup(err_msg);
+ OS::PrintErr("Dart_Cleanup: %s\n", err_msg);
+ return false;
}
- return NULL;
+ return true;
}
@@ -1362,10 +1364,6 @@ DART_EXPORT Dart_Isolate Dart_CreateIsolate(const char* script_uri,
}
Isolate* isolate = Dart::CreateIsolate(isolate_name, *flags);
free(isolate_name);
- if (isolate == NULL) {
- *error = strdup("Isolate creation failed");
- return reinterpret_cast<Dart_Isolate>(NULL);
- }
{
StackZone zone(isolate);
HANDLESCOPE(isolate);
« no previous file with comments | « runtime/vm/dart.cc ('k') | runtime/vm/debugger_api_impl_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698