Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1270313006: Connects PostMessage() for OOPIFs (Closed)

Created:
5 years, 4 months ago by sky
Modified:
5 years, 4 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, penghuang+watch-mandoline_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Connects PostMessage() for OOPIFs BUG=479172, 490221 TEST=none R=fsamuel@chromium.org Committed: https://crrev.com/d30ec60a76d4a68540771754195f5e49c01bc57a Cr-Commit-Position: refs/heads/master@{#342939}

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+233 lines, -38 lines) Patch
M components/html_viewer/ax_provider_apptest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M components/html_viewer/blink_basic_type_converters.h View 1 chunk +4 lines, -0 lines 0 comments Download
M components/html_viewer/blink_basic_type_converters.cc View 2 chunks +19 lines, -5 lines 0 comments Download
M components/html_viewer/document_resource_waiter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/html_viewer/document_resource_waiter.cc View 1 2 chunks +11 lines, -0 lines 0 comments Download
M components/html_viewer/html_frame.h View 2 chunks +5 lines, -2 lines 0 comments Download
M components/html_viewer/html_frame.cc View 4 chunks +71 lines, -4 lines 0 comments Download
M components/html_viewer/html_frame_apptest.cc View 5 chunks +53 lines, -5 lines 0 comments Download
M mandoline/tab/frame.h View 2 chunks +7 lines, -2 lines 0 comments Download
M mandoline/tab/frame.cc View 2 chunks +18 lines, -5 lines 0 comments Download
M mandoline/tab/frame_apptest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M mandoline/tab/frame_tree_delegate.h View 1 chunk +5 lines, -2 lines 0 comments Download
M mandoline/tab/public/interfaces/frame_tree.mojom View 2 chunks +23 lines, -4 lines 0 comments Download
M mandoline/tab/test_frame_tree_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M mandoline/tab/test_frame_tree_delegate.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M mandoline/ui/browser/browser.h View 1 chunk +1 line, -1 line 0 comments Download
M mandoline/ui/browser/browser.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
sky
5 years, 4 months ago (2015-08-11 18:33:38 UTC) #1
Fady Samuel
I'm confused by these NOTREACHED() unimplemented message port thing. Tests seem to indicate that postMessage ...
5 years, 4 months ago (2015-08-11 19:39:07 UTC) #2
sky
On 2015/08/11 19:39:07, Fady Samuel wrote: > I'm confused by these NOTREACHED() unimplemented message port ...
5 years, 4 months ago (2015-08-11 19:40:54 UTC) #3
Fady Samuel
OK lgtm
5 years, 4 months ago (2015-08-11 23:35:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1270313006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1270313006/20001
5 years, 4 months ago (2015-08-11 23:36:42 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-11 23:43:10 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 23:44:02 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d30ec60a76d4a68540771754195f5e49c01bc57a
Cr-Commit-Position: refs/heads/master@{#342939}

Powered by Google App Engine
This is Rietveld 408576698