Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1270313003: Debugger: clear shared function info list when recompiling for liveedit. (Closed)

Created:
5 years, 4 months ago by Yang
Modified:
5 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Debugger: clear shared function info list when recompiling for liveedit. R=bmeurer@chromium.org BUG=chromium:517594 LOG=N

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/compiler.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Yang
5 years, 4 months ago (2015-08-11 11:04:01 UTC) #1
Benedikt Meurer
LGTM.
5 years, 4 months ago (2015-08-11 11:17:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1270313003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1270313003/1
5 years, 4 months ago (2015-08-11 11:19:33 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-11 12:00:41 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9eea3ef5147a5e15256093fb4c36a7598d60d128 Cr-Commit-Position: refs/heads/master@{#30111}
5 years, 4 months ago (2015-08-11 12:00:54 UTC) #6
vogelheim
5 years, 4 months ago (2015-08-11 13:55:59 UTC) #7
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1279613008/ by vogelheim@chromium.org.

The reason for reverting is: Sorry for revert, but this change breaks one of the
webkit-unit-tests. 

Example here:
https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Win/117...

Not sure if the old expectations were right, or the new ones are. :)
.

Powered by Google App Engine
This is Rietveld 408576698