LayoutTests/fast/dom/shadow/closed-mode-deep-combinators.html - Issue 1270313002: Handle closed mode shadow for /deep/ and ::shadow selectors

Side by Side Diff: LayoutTests/fast/dom/shadow/closed-mode-deep-combinators.html

Issue 1270313002: Handle closed mode shadow for /deep/ and ::shadow selectors (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: add a layout test for 2 /deep/s Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« LayoutTests/fast/dom/shadow/closed-mode-deep-combinator-and-shadow-pseudo.html ('K') | « LayoutTests/fast/dom/shadow/closed-mode-deep-combinator-and-shadow-pseudo-expected.txt ('k') | LayoutTests/fast/dom/shadow/closed-mode-deep-combinators-expected.txt » ('j') | Source/core/css/SelectorChecker.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <script src="../../../resources/js-test.js"></script>

	3 <script src="resources/shadow-dom.js"></script>

	4 <body>

	5 <div id="parent"></div>

	6 </body>

	7 <script>

	8 function prepareShadowTree() {

	9 var parent = document.getElementById('parent');

	10 parent.appendChild(

	11 createDOM('div', {id: 'toplevel'},

	12 createDOM('div', {id: 'openhost'},

	13 createShadowRoot({mode: 'open'},

	14 createDOM('div', {id: 'openhost_in_openshadow'},

	15 createShadowRoot({'mode': 'open'},

	16 createDOM('div', {id: 'div_open_open'}))),

	17 createDOM('div', {id: 'closedhost_in_openshadow'},

	18 createShadowRoot({'mode': 'closed'},

	19 createDOM('div', {id: 'div_open_closed'}))))),

	20 createDOM('div', {id: 'closedhost'},

	21 createShadowRoot({mode: 'closed'},

	22 createDOM('div', {id: 'openhost_in_closedshadow'},

	23 createShadowRoot({'mode': 'open'},

	24 createDOM('div', {id: 'div_closed_open'}))),

	25 createDOM('div', {id: 'closedhost_in_closedshadow'},

	26 createShadowRoot({'mode': 'closed'},

	27 createDOM('div', {id: 'div_closed_closed'})))))));

	28 }

	29

	30 prepareShadowTree();

	31

	32 var parent = document.getElementById('parent');

	33 var result = parent.querySelectorAll("div /deep/ div /deep/ div");

	34 shouldBe('result.length', '5');

	35

	36 var expected = [

	37 'openhost',

	38 'openhost_in_openshadow',

	39 'div_open_open',

	40 'closedhost_in_openshadow',

	41 'closedhost'
	hayato 2015/08/20 03:47:11 It looks the order of the nodes returned by queryS It looks the order of the nodes returned by querySelectorAll is inconsistency between for open and closed shadow trees. I guess the spec needs to define the order, but from where this inconsistency came in Blink? This is expected? kochi 2015/08/20 06:04:26 Which do you think is inconsistent? The first 4 e Show quoted text On 2015/08/20 03:47:11, hayato wrote: > It looks the order of the nodes returned by querySelectorAll is inconsistency > between for open and closed shadow trees. > > I guess the spec needs to define the order, but from where this inconsistency > came in Blink? This is expected? Which do you think is inconsistent? The first 4 elements are from 'openhost' tree, whose ancestors are all open (#openhost, #openhost_in_openshadow, #div_open_open#, #closedhost_in_openshadow) and the order is in the document order. The last one is the only element that matches in the second shadow tree, as shadow host itself (#closedhost) is visible from document tree. This comes next to the previous ones, because it's appended after #openhost. hayato 2015/08/20 07:09:59 You are right. My bad. :( Maybe the current namin You are right. My bad. :( Maybe the current naming convention made me confused. It's up to you, but the naming convention of "from-outer-to-inner, instead of "from-inner-to-outer", might be preferred to avoid confusion in this kind of selector test. kochi 2015/08/20 07:32:50 Done. Show quoted text On 2015/08/20 07:09:59, hayato wrote: > You are right. My bad. :( > > Maybe the current naming convention made me confused. > It's up to you, but the naming convention of "from-outer-to-inner, instead of > "from-inner-to-outer", might be preferred to avoid confusion in this kind of > selector test. Done.
	42 ];

	43

	44 var node;

	45 for (var i = 0; i < result.length; ++i) {

	46 node = result[i];

	47 shouldBeEqualToString('node.id', expected[i]);

	48 }

	49 </script>

OLD	NEW