[Sync] Add interface and backend impl for typed URL syncable service

chrome/browser/history/history_backend.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/history/history_backend.h"
 
 #include <algorithm>
 #include <functional>
 #include <list>
 #include <map>
@@ skipping 15 matching lines @@
 #include "chrome/browser/autocomplete/history_url_provider.h"
 #include "chrome/browser/bookmarks/bookmark_service.h"
 #include "chrome/browser/history/download_row.h"
 #include "chrome/browser/history/history_db_task.h"
 #include "chrome/browser/history/history_notifications.h"
 #include "chrome/browser/history/history_publisher.h"
 #include "chrome/browser/history/in_memory_history_backend.h"
 #include "chrome/browser/history/page_usage_data.h"
 #include "chrome/browser/history/select_favicon_frames.h"
 #include "chrome/browser/history/top_sites.h"
+#include "chrome/browser/history/typed_url_syncable_service.h"
 #include "chrome/browser/history/visit_filter.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/url_constants.h"
 #include "googleurl/src/gurl.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
 #include "net/base/registry_controlled_domains/registry_controlled_domain.h"
 #include "sql/error_delegate_util.h"
 
@@ skipping 243 matching lines @@
 
 #if defined(OS_ANDROID)
   file_util::Delete(GetAndroidCacheFileName(), false);
 #endif
 }
 
 void HistoryBackend::Init(const std::string& languages, bool force_fail) {
   if (!force_fail)
     InitImpl(languages);
   delegate_->DBLoaded(id_);
+  typed_url_syncable_service_.reset(new TypedUrlSyncableService(this));
 }
 
 void HistoryBackend::SetOnBackendDestroyTask(MessageLoop* message_loop,
                                              const base::Closure& task) {
   if (!backend_destroy_task_.is_null())
     DLOG(WARNING) << "Setting more than one destroy task, overriding";
   backend_destroy_message_loop_ = message_loop;
   backend_destroy_task_ = task;
 }
 
@@ skipping 858 matching lines @@
       success = true;
 
       // Optionally query the visits.
       if (want_visits)
         db_->GetVisitsForURL(row->id(), visits);
     }
   }
   request->ForwardResult(request->handle(), success, row, visits);
 }
 
+TypedUrlSyncableService* HistoryBackend::GetTypedUrlSyncableService() const {
+  return typed_url_syncable_service_.get();
+}
+
 // Segment usage ---------------------------------------------------------------
 
 void HistoryBackend::DeleteOldSegmentData() {
   if (db_.get())
     db_->DeleteSegmentData(Time::Now() -
                            TimeDelta::FromDays(kSegmentDataRetention));
 }
 
 void HistoryBackend::QuerySegmentUsage(
     scoped_refptr<QuerySegmentUsageRequest> request,
@@ skipping 1666 matching lines @@
   if (!task_scheduled) {
     // No other tasks are scheduled. Process request now.
     ProcessDBTaskImpl();
   }
 }
 
 void HistoryBackend::BroadcastNotifications(
     int type,
     HistoryDetails* details_deleted) {
   // |delegate_| may be NULL if |this| is in the process of closing (closed by
-  // HistoryService -> HistroyBackend::Closing().
-  if (delegate_.get())
+  // HistoryService -> HistoryBackend::Closing().
+  if (delegate_.get()) {
+    // Typed urls sync service is called here to handle deleted urls, including
+    // expirations from ExpireHistoryBackend, new, modified, and visited urls
+    if (typed_url_syncable_service_.get()) {
+      switch (type) {
+        case chrome::NOTIFICATION_HISTORY_URLS_DELETED: {

[brettw, 2013/04/20 05:14:18]

I don't think it makes sense to key off of the notification inside the history
system itself on the same thread. We're trying to delete the notification
service, and using this exceedingly weak coupling inside of one logical
subsystem unnecessarily declarifies things.

Maybe one thing that would be better would be to add these functions on the
delegate interface with the necessary parameters, and have the backend create
the details and issue the notification.

[mgist1, 2013/04/22 20:47:05]

Just to clarify, would it be better to remove this code completely from
BroadcastNotifications and instead call the necessary handler from within the
code that calls BroadcastNotifications (the way the code was before Patch Set
7), and in addition have a wrapper function within
BroadcastNotificationDelegate, implemented by HistoryBackend, to take details
from ExpireHistoryBackend and call OnUrlsDeleted?

+          typed_url_syncable_service_->OnUrlsDeleted(
+              static_cast<history::URLsDeletedDetails*>(details_deleted));
+          break;
+        }
+        case chrome::NOTIFICATION_HISTORY_URLS_MODIFIED: {
+          typed_url_syncable_service_->OnUrlsModified(
+              static_cast<history::URLsModifiedDetails*>(details_deleted));
+          break;
+        }
+        case chrome::NOTIFICATION_HISTORY_URL_VISITED: {
+          typed_url_syncable_service_->OnUrlVisited(
+              static_cast<history::URLVisitedDetails*>(details_deleted));
+          break;
+        }
+        default:
+          break;
+      }
+    }
     delegate_->BroadcastNotifications(type, details_deleted);
-  else
+  } else {
     delete details_deleted;
+  }
 }
 
 // Deleting --------------------------------------------------------------------
 
 void HistoryBackend::DeleteAllHistory() {
   // Our approach to deleting all history is:
   //  1. Copy the bookmarks and their dependencies to new tables with temporary
   //     names.
   //  2. Delete the original tables. Since tables can not share pages, we know
   //     that any data we don't want to keep is now in an unused page.
@@ skipping 183 matching lines @@
   info.url_id = visit.url_id;
   info.time = visit.visit_time;
   info.transition = visit.transition;
   // If we don't have a delegate yet during setup or shutdown, we will drop
   // these notifications.
   if (delegate_.get())
     delegate_->NotifyVisitDBObserversOnAddVisit(info);
 }
 
 }  // namespace history