Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: Source/WebCore/html/HTMLInputElement.cpp

Issue 12703031: Revert 146726 "AXObjectCache gets recreated during document tear..." (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1453/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org) 7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
10 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 10 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
(...skipping 879 matching lines...) Expand 10 before | Expand all | Expand 10 after
890 890
891 if (CheckedRadioButtons* buttons = checkedRadioButtons()) 891 if (CheckedRadioButtons* buttons = checkedRadioButtons())
892 buttons->updateCheckedState(this); 892 buttons->updateCheckedState(this);
893 if (renderer() && renderer()->style()->hasAppearance()) 893 if (renderer() && renderer()->style()->hasAppearance())
894 renderer()->theme()->stateChanged(renderer(), CheckedState); 894 renderer()->theme()->stateChanged(renderer(), CheckedState);
895 setNeedsValidityCheck(); 895 setNeedsValidityCheck();
896 896
897 // Ideally we'd do this from the render tree (matching 897 // Ideally we'd do this from the render tree (matching
898 // RenderTextView), but it's not possible to do it at the moment 898 // RenderTextView), but it's not possible to do it at the moment
899 // because of the way the code is structured. 899 // because of the way the code is structured.
900 if (renderer()) { 900 if (renderer() && AXObjectCache::accessibilityEnabled())
901 if (AXObjectCache* cache = renderer()->document()->existingAXObjectCache ()) 901 renderer()->document()->axObjectCache()->checkedStateChanged(this);
902 cache->checkedStateChanged(this);
903 }
904 902
905 // Only send a change event for items in the document (avoid firing during 903 // Only send a change event for items in the document (avoid firing during
906 // parsing) and don't send a change event for a radio button that's getting 904 // parsing) and don't send a change event for a radio button that's getting
907 // unchecked to match other browsers. DOM is not a useful standard for this 905 // unchecked to match other browsers. DOM is not a useful standard for this
908 // because it says only to fire change events at "lose focus" time, which is 906 // because it says only to fire change events at "lose focus" time, which is
909 // definitely wrong in practice for these types of elements. 907 // definitely wrong in practice for these types of elements.
910 if (eventBehavior != DispatchNoEvent && inDocument() && m_inputType->shouldS endChangeEventAfterCheckedChanged()) { 908 if (eventBehavior != DispatchNoEvent && inDocument() && m_inputType->shouldS endChangeEventAfterCheckedChanged()) {
911 setTextAsOfLastFormControlChangeEvent(String()); 909 setTextAsOfLastFormControlChangeEvent(String());
912 dispatchFormControlChangeEvent(); 910 dispatchFormControlChangeEvent();
913 } 911 }
(...skipping 1066 matching lines...) Expand 10 before | Expand all | Expand 10 after
1980 } 1978 }
1981 1979
1982 #if ENABLE(INPUT_MULTIPLE_FIELDS_UI) 1980 #if ENABLE(INPUT_MULTIPLE_FIELDS_UI)
1983 PassRefPtr<RenderStyle> HTMLInputElement::customStyleForRenderer() 1981 PassRefPtr<RenderStyle> HTMLInputElement::customStyleForRenderer()
1984 { 1982 {
1985 return m_inputType->customStyleForRenderer(document()->styleResolver()->styl eForElement(this)); 1983 return m_inputType->customStyleForRenderer(document()->styleResolver()->styl eForElement(this));
1986 } 1984 }
1987 #endif 1985 #endif
1988 1986
1989 } // namespace 1987 } // namespace
OLDNEW
« no previous file with comments | « Source/WebCore/editing/mac/FrameSelectionMac.mm ('k') | Source/WebCore/html/HTMLSelectElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698